Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: lib/compiler/implementation/source_map_builder.dart

Issue 10636003: Use JSON.printOn in SourceMapBuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/source_map_builder.dart
diff --git a/lib/compiler/implementation/source_map_builder.dart b/lib/compiler/implementation/source_map_builder.dart
index 3e5fb6f991deed84d837ca4f90d1a746b3be4055..ddbe2e67abf29ada04b5932e5487118f0da63408 100644
--- a/lib/compiler/implementation/source_map_builder.dart
+++ b/lib/compiler/implementation/source_map_builder.dart
@@ -65,10 +65,12 @@ class SourceMapBuilder {
writeEntry(entry, targetFile, buffer);
});
buffer.add('",\n');
- // TODO(podivilov): serialize lists directly to buffer.
- buffer.add(' "sources": ${JSON.stringify(sourceUrlList)},\n');
- buffer.add(' "names": ${JSON.stringify(sourceNameList)}\n');
- buffer.add('}\n');
+ buffer.add(' "sources": ');
+ JSON.printOn(sourceUrlList, buffer);
+ buffer.add(',\n');
+ buffer.add(' "names": ');
+ JSON.printOn(sourceNameList, buffer);
+ buffer.add('\n}\n');
return buffer.toString();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698