Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 10635024: Return different IDs from TestWebGraphicsContext3D::createTexture (Closed)

Created:
8 years, 6 months ago by jamesr
Modified:
8 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, dhollowa+watch_chromium.org, jonathan.backer
Visibility:
Public.

Description

Return different IDs from TestWebGraphicsContext3D::createTexture I'm adding stricter ASSERT()s on the WebKit side making sure that we correctly matching createTexture()/deleteTexture() calls. This assumes that texture IDs do not overlap, which is true (hopefully!) for all real contexts but not for TestWebGraphicsContext3D. This makes the test context return different IDs. Without it, aura_unittests hit ASSERT()s whenever my WebKit patch rolls into the tree. BUG=none TEST=run aura_unittests with the WebKit patch at https://bugs.webkit.org/show_bug.cgi?id=89045 applied Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143740

Patch Set 1 #

Total comments: 1

Patch Set 2 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/compositor/test_web_graphics_context_3d.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test_web_graphics_context_3d.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
8 years, 6 months ago (2012-06-22 20:11:29 UTC) #1
piman
lgtm
8 years, 6 months ago (2012-06-22 20:14:10 UTC) #2
piman
lgtm https://chromiumcodereview.appspot.com/10635024/diff/1/ui/compositor/test_web_graphics_context_3d.cc File ui/compositor/test_web_graphics_context_3d.cc (right): https://chromiumcodereview.appspot.com/10635024/diff/1/ui/compositor/test_web_graphics_context_3d.cc#newcode13 ui/compositor/test_web_graphics_context_3d.cc:13: : next_texture_id_(1) {} nit: 2 extra spaces before ...
8 years, 6 months ago (2012-06-22 20:18:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10635024/9001
8 years, 6 months ago (2012-06-22 20:53:52 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 23:49:57 UTC) #5
Change committed as 143740

Powered by Google App Engine
This is Rietveld 408576698