Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10634037: webkit: Include stdio.h in cpp_binding_example (Closed)

Created:
8 years, 6 months ago by Simon Que
Modified:
8 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://git.chromium.org/git/chromium/src@master
Visibility:
Public.

Description

webkit: Include stdio.h in cpp_binding_example In order to use printf(), <stdio.h> should be explicitly included. BUG=chromium:134180 TEST=build cpp_binding_example successfully Change-Id: I372d726672b0f252649afa94862a829e29245126 Signed-off-by: Mandeep Singh Baines <msb@chromium.org>; Signed-off-by: Simon Que <sque@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144381

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed include order, rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/glue/cpp_binding_example.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Xianzhu
http://codereview.chromium.org/10634037/diff/1/webkit/glue/cpp_binding_example.cc File webkit/glue/cpp_binding_example.cc (right): http://codereview.chromium.org/10634037/diff/1/webkit/glue/cpp_binding_example.cc#newcode8 webkit/glue/cpp_binding_example.cc:8: #include <stdio.h> Please move this line below '#include "cpp_binding_example.h"'. ...
8 years, 6 months ago (2012-06-26 13:14:15 UTC) #1
Simon Que
https://chromiumcodereview.appspot.com/10634037/diff/1/webkit/glue/cpp_binding_example.cc File webkit/glue/cpp_binding_example.cc (right): https://chromiumcodereview.appspot.com/10634037/diff/1/webkit/glue/cpp_binding_example.cc#newcode8 webkit/glue/cpp_binding_example.cc:8: #include <stdio.h> On 2012/06/26 13:14:15, Xianzhu wrote: > Please ...
8 years, 6 months ago (2012-06-26 19:17:50 UTC) #2
Xianzhu
LGTM, but I'm not an owner of the directory.
8 years, 6 months ago (2012-06-27 01:15:21 UTC) #3
Simon Que
On 2012/06/27 01:15:21, Xianzhu wrote: > LGTM, but I'm not an owner of the directory. ...
8 years, 6 months ago (2012-06-27 01:17:11 UTC) #4
Xianzhu
On 2012/06/27 01:17:11, Simon Que wrote: > On 2012/06/27 01:15:21, Xianzhu wrote: > > LGTM, ...
8 years, 6 months ago (2012-06-27 01:24:27 UTC) #5
Simon Que
8 years, 6 months ago (2012-06-27 01:33:04 UTC) #6
Simon Que
8 years, 6 months ago (2012-06-27 01:33:39 UTC) #7
jamesr
lgtm
8 years, 6 months ago (2012-06-27 01:33:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/10634037/4001
8 years, 6 months ago (2012-06-27 01:38:29 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-27 02:42:51 UTC) #10
Change committed as 144381

Powered by Google App Engine
This is Rietveld 408576698