Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Side by Side Diff: runtime/vm/intermediate_language.cc

Issue 10634032: Fixed a typo, one more reason to get rid of StrictCompare vs StrictCompareComp distinction. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/intermediate_language.h" 5 #include "vm/intermediate_language.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/flow_graph_builder.h" 8 #include "vm/flow_graph_builder.h"
9 #include "vm/flow_graph_compiler.h" 9 #include "vm/flow_graph_compiler.h"
10 #include "vm/locations.h" 10 #include "vm/locations.h"
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 } 1068 }
1069 1069
1070 1070
1071 void StoreContextComp::EmitNativeCode(FlowGraphCompiler* compiler) { 1071 void StoreContextComp::EmitNativeCode(FlowGraphCompiler* compiler) {
1072 // Nothing to do. Context register were loaded by register allocator. 1072 // Nothing to do. Context register were loaded by register allocator.
1073 ASSERT(locs()->in(0).reg() == CTX); 1073 ASSERT(locs()->in(0).reg() == CTX);
1074 } 1074 }
1075 1075
1076 1076
1077 LocationSummary* StrictCompareComp::MakeLocationSummary() const { 1077 LocationSummary* StrictCompareComp::MakeLocationSummary() const {
1078 if (!is_fused_with_branch()) { 1078 if (is_fused_with_branch()) {
1079 const intptr_t kNumInputs = 2;
1080 const intptr_t kNumTemps = 0;
1081 LocationSummary* locs = new LocationSummary(kNumInputs,
1082 kNumTemps,
1083 LocationSummary::kNoCall,
1084 LocationSummary::kBranch);
1085 locs->set_in(0, Location::RequiresRegister());
1086 locs->set_in(1, Location::RequiresRegister());
1087 return locs;
1088 } else {
1079 return LocationSummary::Make(2, Location::SameAsFirstInput()); 1089 return LocationSummary::Make(2, Location::SameAsFirstInput());
1080 } else {
1081 return LocationSummary::Make(2, Location::NoLocation());
1082 } 1090 }
1083 } 1091 }
1084 1092
1085 1093
1086 void StrictCompareComp::EmitNativeCode(FlowGraphCompiler* compiler) { 1094 void StrictCompareComp::EmitNativeCode(FlowGraphCompiler* compiler) {
1087 Register left = locs()->in(0).reg(); 1095 Register left = locs()->in(0).reg();
1088 Register right = locs()->in(1).reg(); 1096 Register right = locs()->in(1).reg();
1089 1097
1090 ASSERT(kind() == Token::kEQ_STRICT || kind() == Token::kNE_STRICT); 1098 ASSERT(kind() == Token::kEQ_STRICT || kind() == Token::kNE_STRICT);
1091 Condition true_condition = (kind() == Token::kEQ_STRICT) ? EQUAL : NOT_EQUAL; 1099 Condition true_condition = (kind() == Token::kEQ_STRICT) ? EQUAL : NOT_EQUAL;
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1299 const ExternalLabel label(closure_function.ToCString(), stub.EntryPoint()); 1307 const ExternalLabel label(closure_function.ToCString(), stub.EntryPoint());
1300 compiler->GenerateCall(token_index(), try_index(), &label, 1308 compiler->GenerateCall(token_index(), try_index(), &label,
1301 PcDescriptors::kOther); 1309 PcDescriptors::kOther);
1302 __ Drop(2); // Discard type arguments and receiver. 1310 __ Drop(2); // Discard type arguments and receiver.
1303 } 1311 }
1304 1312
1305 1313
1306 #undef __ 1314 #undef __
1307 1315
1308 } // namespace dart 1316 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698