Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4361)

Unified Diff: chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js

Issue 10634020: [FileManager] Do drive search incrementally (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js b/chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js
index df81bbaef14d54cfa7dc8844f46a6dd372d3ff16..e0b90c96fa1fb384e7eac1d9daa86ceca89b86f9 100644
--- a/chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js
@@ -27,12 +27,17 @@ chromeHidden.registerCustomHook('fileBrowserPrivate', function(bindingsAPI) {
apiFunctions.setCustomCallback('searchGData',
function(name, request, response) {
- if (response && !response.error && response) {
- for (var i = 0; i < response.length; i++)
- response[i] = GetExternalFileEntry(response[i]);
+ if (response && !response.error && response.entries) {
+ for (var i = 0; i < response.entries.length; i++)
+ response.entries[i] = GetExternalFileEntry(response.entries[i]);
}
+
+ // So |request.callback| doesn't break if response is not defined.
+ if (!response)
+ response = {};
+
if (request.callback)
- request.callback(response);
+ request.callback(response.entries, response.nextFeed);
request.callback = null;
});
});

Powered by Google App Engine
This is Rietveld 408576698