Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 10633019: Try to fix a crash in the var tracking. (Closed)

Created:
8 years, 6 months ago by brettw
Modified:
8 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews
Visibility:
Public.

Description

Try to fix a crash in the var tracking. I think what is happening is that the list is mutated as we iterate over it. This is actually quite a resonable thing to do: we're deleting objects, and those objects may hold refs to other objects in our list. BUG=http://crbug.com/133951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143644

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M ppapi/proxy/plugin_var_tracker.cc View 1 1 chunk +30 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
8 years, 6 months ago (2012-06-21 23:43:07 UTC) #1
raymes
lgtm
8 years, 6 months ago (2012-06-21 23:56:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10633019/1
8 years, 6 months ago (2012-06-22 00:40:57 UTC) #3
commit-bot: I haz the power
Try job failure for 10633019-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-22 00:57:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10633019/5
8 years, 6 months ago (2012-06-22 16:57:22 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 18:15:29 UTC) #6
Change committed as 143644

Powered by Google App Engine
This is Rietveld 408576698