Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2663)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 10632017: Revert "Added the ability to filter which tests are run by name, using a --filter argument passed t… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index d7090d4a3051b1e71a7ee93ee51ef97f90ec8e62..5eabfd167a912a7af096b24046eb9d89fe4b7bdd 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -446,9 +446,6 @@ class StandardTestSuite implements TestSuite {
String testPath =
new File(info.filename).fullPathSync().replaceAll('\\', '/');
String tempDir = createOutputDirectory(testPath, '');
- if (configuration['filter'] != '') {
- args.add('--filter="${configuration["filter"]}"');
- }
args.add('--out=$tempDir/out.js');
List<Command> commands = <Command>[new Command(shellPath(), args)];
if (configuration['runtime'] == 'd8') {
@@ -457,9 +454,6 @@ class StandardTestSuite implements TestSuite {
}
return commands;
} else {
- if (configuration['filter'] != '') {
- args.add('--filter="${configuration["filter"]}"');
- }
return <Command>[new Command(shellPath(), args)];
}
}
@@ -569,8 +563,7 @@ class StandardTestSuite implements TestSuite {
File file = new File(dartWrapperFilename);
RandomAccessFile dartWrapper = file.openSync(FileMode.WRITE);
dartWrapper.writeStringSync(
- DartTestWrapper(dartDir, dartLibraryFilename,
- configuration['filter']));
+ DartTestWrapper(dartDir, dartLibraryFilename));
dartWrapper.closeSync();
} else {
dartWrapperFilename = testPath;
« no previous file with comments | « dart/tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698