Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: dart/lib/unittest/config.dart

Issue 10632017: Revert "Added the ability to filter which tests are run by name, using a --filter argument passed t… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/lib/unittest/unittest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/unittest/config.dart
diff --git a/dart/lib/unittest/config.dart b/dart/lib/unittest/config.dart
index 1b9aa606ba3af60b74c581e05b00c4de32fc3a88..19560de956054ed58d40b81d0e95a26b9a8998c5 100644
--- a/dart/lib/unittest/config.dart
+++ b/dart/lib/unittest/config.dart
@@ -61,10 +61,7 @@ class Configuration {
if (passed == 0 && failed == 0 && errors == 0) {
print('No tests found.');
// This is considered a failure too: if this happens you probably have a
- // bug in your unit tests, unless you are filtering.
- if (getFilter() != null) {
- success = true;
- }
+ // bug in your unit tests.
} else if (failed == 0 && errors == 0 && uncaughtError == null) {
print('All $passed tests passed.');
success = true;
« no previous file with comments | « no previous file | dart/lib/unittest/unittest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698