Issue 10632015: filename_rules: Separate chromeos from x11 rule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10632015: filename_rules: Separate chromeos from x11 rule (Closed)

Created:
8 years, 6 months ago by Simon Que

Modified:
8 years, 6 months ago

Reviewers:
oshima, Mandeep Singh Baines, Daniel Erat

CC:
chromium-reviews

Base URL:
https://git.chromium.org/git/chromium/src@master

Visibility:
Public.

More Reviews

Description

filename_rules: Separate chromeos from x11 rule The x11 exclusion rule should not be excluding chromeos files. There is a separate chromeos exclusion rule for that. Also adding unit test exclusion to the chromeos rule. BUG=chromium:134081 TEST=build w/ tests successfully Signed-off-by: Simon Que <sque@chromium.org>; Change-Id: I2e462dcbda6ffc3636886a1f877a5554b7f6a1a9 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143694

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build/filename_rules.gypi	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm http://codereview.chromium.org/10632015/diff/1/build/filename_rules.gypi File build/filename_rules.gypi (left): http://codereview.chromium.org/10632015/diff/1/build/filename_rules.gypi#oldcode65 build/filename_rules.gypi:65: ['exclude', '_(chromeos|x|x11)(_unittest)?\\.(h|cc)$'], oh, i didn't know we had ...

8 years, 6 months ago (2012-06-22 15:38:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/10632015/1

8 years, 6 months ago (2012-06-22 18:39:55 UTC) #2

Change committed as 143694

Expand Messages | Collapse Messages