runtime/vm/intermediate_language_x64.cc - Issue 10632010: Fix excessive deoptimizations in Meteor: kSHL on two Smi-s can easily overflow, which led to deopti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 10632010: Fix excessive deoptimizations in Meteor: kSHL on two Smi-s can easily overflow, which led to deopti… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_x64.cc

===================================================================

--- runtime/vm/intermediate_language_x64.cc (revision 8998)

+++ runtime/vm/intermediate_language_x64.cc (working copy)

@@ -1759,7 +1759,7 @@

Label* deopt = compiler->AddDeoptStub(instance_call()->cid(),

instance_call()->token_index(),

instance_call()->try_index(),

- kDeoptSmiBinaryOp,

+ kDeoptUnaryOp,

value);

if (test_class_id == kSmi) {

__ testq(value, Immediate(kSmiTagMask));

@@ -1812,7 +1812,7 @@