Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 10632003: Implement use_system_icu for Android. (Closed)

Created:
8 years, 6 months ago by Torne
Modified:
8 years, 5 months ago
Reviewers:
Philippe
CC:
Steve Block
Base URL:
http://git.chromium.org/chromium/deps/icu46.git@master
Visibility:
Public.

Description

Implement use_system_icu for Android. It will be useful to be able to use the Android system version of ICU on some future chromium build configs. Add the appropriate options to the gyp file to enable this, since icu-config can't be used for crosscompilation.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M icu.gyp View 1 chunk +25 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Torne
Hi jshin, Hoping you might be the right person to review this (as you wrote ...
8 years, 6 months ago (2012-06-21 15:19:13 UTC) #1
Torne
Adam, would you be able to review this? It doesn't look like anyone is very ...
8 years, 5 months ago (2012-07-02 13:16:32 UTC) #2
Torne
8 years, 5 months ago (2012-07-10 12:31:40 UTC) #3
Philippe
8 years, 5 months ago (2012-07-10 12:35:25 UTC) #4
LGTM.

Thanks Richard!

Powered by Google App Engine
This is Rietveld 408576698