Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 10631009: Removes TabFinder. We're not going to use it. (Closed)

Created:
8 years, 6 months ago by sky
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Removes TabFinder. We're not going to use it. TBR since this is purely code removal. BUG=none TEST=none R=ben@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143604

Patch Set 1 #

Patch Set 2 : git rm tab_finder.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -391 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +0 lines, -15 lines 0 comments Download
D chrome/browser/ui/tabs/tab_finder.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/ui/tabs/tab_finder.cc View 1 1 chunk +0 lines, -246 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
8 years, 6 months ago (2012-06-21 22:59:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10631009/1008
8 years, 6 months ago (2012-06-21 23:00:00 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 6 months ago (2012-06-21 23:00:30 UTC) #3
commit-bot: I haz the power
Try job failure for 10631009-1008 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-22 00:05:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10631009/1008
8 years, 6 months ago (2012-06-22 00:17:55 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 01:16:29 UTC) #6
Try job failure for 10631009-1008 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698