Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 10630009: Merge 120828 - [Chromium] IndexedDB: Don't close database if pending connections are in flight (Closed)

Created:
8 years, 6 months ago by jsbell
Modified:
8 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 120828 - [Chromium] IndexedDB: Don't close database if pending connections are in flight https://bugs.webkit.org/show_bug.cgi?id=89512 Source/WebCore: Add a counter tracking connections between the two phases, which is used along with the completed connection count to determine the total number of connections. Reviewed by Tony Chang. Test: webkit_unit_tests --gtest_filter='IDBDatabaseBackendTest.ConnectionLifecycle' * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::connectionCount): (WebCore): (WebCore::IDBDatabaseBackendImpl::processPendingCalls): (WebCore::IDBDatabaseBackendImpl::transaction): (WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks): (WebCore::IDBDatabaseBackendImpl::openConnection): (WebCore::IDBDatabaseBackendImpl::close): * Modules/indexeddb/IDBDatabaseBackendImpl.h: (IDBDatabaseBackendImpl): * Modules/indexeddb/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::openInternal): * inspector/InspectorIndexedDBAgent.cpp: (WebCore): Source/WebKit/chromium: Reviewed by Tony Chang. * tests/IDBDatabaseBackendTest.cpp: (MockIDBCallbacks): (WebCore::MockIDBCallbacks::create): (WebCore::MockIDBCallbacks::MockIDBCallbacks): (WebCore): (FakeIDBDatabaseCallbacks): (WebCore::FakeIDBDatabaseCallbacks::create): (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks): (WebCore::TEST): TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -14 lines) Patch
M Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp View 5 chunks +17 lines, -5 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorIndexedDBAgent.cpp View 14 chunks +58 lines, -8 lines 0 comments Download
M Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jsbell
8 years, 6 months ago (2012-06-21 19:27:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698