Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 10629011: Disable set -e for extract build step (Closed)

Created:
8 years, 6 months ago by Isaac (away)
Modified:
8 years, 6 months ago
Reviewers:
Yaron, newt (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Disable set -e for extract build step This python script is returning warnings via error codes and we don't want to halt our tests from these warnings. BUG=132707 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143550

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M build/android/buildbot_functions.sh View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Isaac (away)
8 years, 6 months ago (2012-06-22 00:12:09 UTC) #1
newt (away)
LGTM with one nit https://chromiumcodereview.appspot.com/10629011/diff/1/build/android/buildbot_functions.sh File build/android/buildbot_functions.sh (right): https://chromiumcodereview.appspot.com/10629011/diff/1/build/android/buildbot_functions.sh#newcode279 build/android/buildbot_functions.sh:279: if (( $extract_exitcode > 1 ...
8 years, 6 months ago (2012-06-22 00:40:19 UTC) #2
Isaac (away)
8 years, 6 months ago (2012-06-22 02:15:00 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-22 02:15:15 UTC) #4
Isaac (away)
8 years, 6 months ago (2012-06-22 02:27:53 UTC) #5
Yaron
https://chromiumcodereview.appspot.com/10629011/diff/5001/build/android/buildbot_functions.sh File build/android/buildbot_functions.sh (right): https://chromiumcodereview.appspot.com/10629011/diff/5001/build/android/buildbot_functions.sh#newcode275 build/android/buildbot_functions.sh:275: set +x Do you mean "set +e" ? "x" ...
8 years, 6 months ago (2012-06-22 02:31:50 UTC) #6
Isaac (away)
yep, should have been set +e. Don't need to reenable -- am using a subshell ...
8 years, 6 months ago (2012-06-22 02:56:16 UTC) #7
Yaron
lgtm
8 years, 6 months ago (2012-06-22 03:03:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10629011/6001
8 years, 6 months ago (2012-06-22 03:03:55 UTC) #9
commit-bot: I haz the power
Try job failure for 10629011-6001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-22 03:56:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10629011/6001
8 years, 6 months ago (2012-06-22 05:09:32 UTC) #11
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 06:36:09 UTC) #12
Change committed as 143550

Powered by Google App Engine
This is Rietveld 408576698