Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10629003: Adding support for the SpeechRecognition.maxAlternatives JS API parameter (Speech CL2.5) (Closed)

Created:
8 years, 6 months ago by Primiano Tucci (use gerrit)
Modified:
8 years, 5 months ago
Reviewers:
hans, Satish, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Satish, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Adding support for the SpeechRecognition.maxAlternatives JS API parameter (Speech CL2.5) BUG=116954 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144487

Patch Set 1 #

Patch Set 2 : Small nits #

Total comments: 4

Patch Set 3 : Turned max_hypotheses to unsigned int #

Total comments: 4

Patch Set 4 : Nits + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M content/browser/speech/google_one_shot_remote_engine.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/speech/google_streaming_remote_engine.cc View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/speech/input_tag_speech_dispatcher_host.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/speech/speech_recognition_engine.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/speech/speech_recognition_engine.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/speech_recognition_messages.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/speech_recognition_session_config.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/speech_recognition_session_config.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/speech_recognition_dispatcher.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Primiano Tucci (use gerrit)
Note, this CL is diff-ed on top of CL2.3 (not yet landed)
8 years, 6 months ago (2012-06-21 11:22:43 UTC) #1
hans
lgtm, thanks https://chromiumcodereview.appspot.com/10629003/diff/3001/content/browser/speech/speech_recognition_engine.h File content/browser/speech/speech_recognition_engine.h (right): https://chromiumcodereview.appspot.com/10629003/diff/3001/content/browser/speech/speech_recognition_engine.h#newcode59 content/browser/speech/speech_recognition_engine.h:59: int max_hypotheses; this is actually unsigned in ...
8 years, 6 months ago (2012-06-21 12:38:56 UTC) #2
Primiano Tucci (use gerrit)
https://chromiumcodereview.appspot.com/10629003/diff/3001/content/browser/speech/speech_recognition_engine.h File content/browser/speech/speech_recognition_engine.h (right): https://chromiumcodereview.appspot.com/10629003/diff/3001/content/browser/speech/speech_recognition_engine.h#newcode59 content/browser/speech/speech_recognition_engine.h:59: int max_hypotheses; On 2012/06/21 12:38:56, hans wrote: > this ...
8 years, 6 months ago (2012-06-21 13:28:25 UTC) #3
hans
http://codereview.chromium.org/10629003/diff/1012/content/browser/speech/input_tag_speech_dispatcher_host.cc File content/browser/speech/input_tag_speech_dispatcher_host.cc (right): http://codereview.chromium.org/10629003/diff/1012/content/browser/speech/input_tag_speech_dispatcher_host.cc#newcode20 content/browser/speech/input_tag_speech_dispatcher_host.cc:20: const uint32 kMaxHypothesesForSpeechInputTag = 6; no need to indent ...
8 years, 6 months ago (2012-06-27 09:53:10 UTC) #4
Primiano Tucci (use gerrit)
http://codereview.chromium.org/10629003/diff/1012/content/browser/speech/input_tag_speech_dispatcher_host.cc File content/browser/speech/input_tag_speech_dispatcher_host.cc (right): http://codereview.chromium.org/10629003/diff/1012/content/browser/speech/input_tag_speech_dispatcher_host.cc#newcode20 content/browser/speech/input_tag_speech_dispatcher_host.cc:20: const uint32 kMaxHypothesesForSpeechInputTag = 6; On 2012/06/27 09:53:10, hans ...
8 years, 6 months ago (2012-06-27 10:01:26 UTC) #5
Primiano Tucci (use gerrit)
+jam for owner approval on /content (outside speech)
8 years, 6 months ago (2012-06-27 10:01:35 UTC) #6
jam
lgtm
8 years, 5 months ago (2012-06-27 16:06:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/10629003/17001
8 years, 5 months ago (2012-06-27 16:28:15 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 17:48:58 UTC) #9 
Change committed as 144487

Powered by Google App Engine
This is Rietveld 408576698