Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 10628008: If there is a device id use that instead of a new one for re-enrolling. (Closed)

Created:
8 years, 6 months ago by pastarmovj
Modified:
8 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

If there is a device id use that instead of a new one for re-enrolling. The original device id is stored in the install attributes and we can read it from there and reuse it instead of generating a new one. BUG=chromium-os:26157 TEST=Enroll. Login. Stop UI.Delete /var/lib/whitelist/policy.Start UI. Re-enrollment should still succeed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_controller.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/policy/cloud_policy_data_store.h View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/cloud_policy_data_store.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_token_fetcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pastarmovj
Can you please rubber stamp this version which properly initializes the bool :)
8 years, 6 months ago (2012-06-21 17:17:13 UTC) #1
pastarmovj
On 2012/06/21 17:17:13, pastarmovj wrote: > Can you please rubber stamp this version which properly ...
8 years, 6 months ago (2012-06-25 08:54:09 UTC) #2
Mattias Nissler (ping if slow)
LGTM
8 years, 6 months ago (2012-06-25 09:01:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/10628008/1
8 years, 6 months ago (2012-06-25 09:06:01 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-25 10:49:20 UTC) #5
Change committed as 143892

Powered by Google App Engine
This is Rietveld 408576698