Issue 10628007: Resolve typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10628007: Resolve typedefs. (Closed)

Created:
8 years, 6 months ago by karlklose

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Resolve typedefs. This CL will be landed in http://codereview.chromium.org/10834061/ since Karl is occupied otherwise.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -92 lines)			Patch
M	lib/compiler/implementation/elements/elements.dart	View	1 2	3 chunks	+16 lines, -6 lines	2 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1 2	8 chunks	+188 lines, -81 lines	2 comments	Download
M	lib/compiler/implementation/typechecker.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View		2 chunks	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 6 months ago (2012-06-22 08:59:11 UTC) #2

Hi Karl,

I should be in the office after lunch. Let's go over the details face-to-face.
I'm a little confused by this.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10628007/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10628007/diff/2002/lib/compiler/implem...
lib/compiler/implementation/elements/elements.dart:41: static final int
IS_EXTENDABLE = CLASS;
Could you add a TODO that this will be legal when we implement the call
operator?

https://chromiumcodereview.appspot.com/10628007/diff/2002/lib/compiler/implem...
lib/compiler/implementation/elements/elements.dart:390:
LinkedHashMap<SourceString, TypeVariableElement> typeParameters;
I think it is overkill to have a map here. A list (link) of type variable
element should be sufficient.

https://chromiumcodereview.appspot.com/10628007/diff/2002/lib/compiler/implem...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10628007/diff/2002/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:215: Scope context = new
TopScope(element.getLibrary());
Why are you calling a "scope" a "context"?

https://chromiumcodereview.appspot.com/10628007/diff/2002/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:221: context = new
TypeVariablesScope(context, contextElement,
Why is this not set up when resolving the type alias?

This seems very ad-hoc to me. I'm not sure I understand this method. Something
appears very wrong in that it tries to solve a type annotation in the context of
an element.

Expand Messages | Collapse Messages