Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: webkit/plugins/npapi/plugin_host.cc

Issue 10628004: Remove support for the QuickDraw NPAPI drawing model (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/npapi/plugin_host.cc
diff --git a/webkit/plugins/npapi/plugin_host.cc b/webkit/plugins/npapi/plugin_host.cc
index 276e7b09c031d6e722ea21c414e74c0e4c3c32b0..d8a17bb9cedd695ef27ff9fc12432a7346d57434 100644
--- a/webkit/plugins/npapi/plugin_host.cc
+++ b/webkit/plugins/npapi/plugin_host.cc
@@ -798,24 +798,12 @@ NPError NPN_GetValue(NPP id, NPNVariable variable, void* value) {
rv = NPERR_NO_ERROR;
break;
}
-#ifndef NP_NO_QUICKDRAW
- case NPNVsupportsQuickDrawBool: {
- // We do not admit to supporting the QuickDraw drawing model. The logic
- // here is that our QuickDraw plugin support is so rudimentary that we
- // only want to use it as a fallback to keep plugins from crashing: if a
- // plugin knows enough to ask, we want them to use CoreGraphics.
- NPBool* supports_qd = reinterpret_cast<NPBool*>(value);
- *supports_qd = false;
- rv = NPERR_NO_ERROR;
- break;
- }
-#endif
case NPNVsupportsCoreGraphicsBool:
#ifndef NP_NO_CARBON
case NPNVsupportsCarbonBool:
#endif
case NPNVsupportsCocoaBool: {
- // we do support these drawing and event models.
+ // These drawing and event models are always supported.
NPBool* supports_model = reinterpret_cast<NPBool*>(value);
*supports_model = true;
rv = NPERR_NO_ERROR;
@@ -841,9 +829,12 @@ NPError NPN_GetValue(NPP id, NPNVariable variable, void* value) {
rv = NPERR_NO_ERROR;
break;
}
+#ifndef NP_NO_QUICKDRAW
+ case NPNVsupportsQuickDrawBool:
+#endif
case NPNVsupportsOpenGLBool: {
- // This drawing model was never widely supported, and we don't plan to
- // support it.
+ // These drawing models are never supported. OpenGL was never widely
+ // supported, and QuickDraw has been deprecated for years.
NPBool* supports_model = reinterpret_cast<NPBool*>(value);
*supports_model = false;
rv = NPERR_NO_ERROR;
« no previous file with comments | « webkit/plugins/npapi/coregraphics_private_symbols_mac.h ('k') | webkit/plugins/npapi/quickdraw_drawing_manager_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698