Issue 10627017: Removes compile-time error from implementing the same interface more than once

Issue 10627017: Removes compile-time error from implementing the same interface more than once (Closed)

Created:
8 years, 6 months ago by zundel

Modified:
8 years, 6 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org, cshapiro

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removes compile-time error from implementing the same interface more than once This change allows inheritenance of the same interface with different parameterization, but puts out a (currently non spec) warning if the resulting two interface types are not assignable to each other. Issue 2495 http://code.google.com/p/dart/issues/detail?id=2495 Issue 3803 http://code.google.com/p/dart/issues/detail?id=3803 Committed: https://code.google.com/p/dart/source/detail?r=9035

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -68 lines)			Patch
M	compiler/java/com/google/dart/compiler/ErrorSeverity.java	View	1 chunk	+6 lines, -1 line	1 comment	Download
M	compiler/java/com/google/dart/compiler/resolver/ClassElement.java	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java	View	7 chunks	+12 lines, -16 lines	0 comments	Download
D	compiler/java/com/google/dart/compiler/resolver/DuplicatedInterfaceException.java	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	4 chunks	+40 lines, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	4 chunks	+35 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://chromiumcodereview.appspot.com/10627017/diff/1/compiler/java/com/google/dart/compiler/ErrorSeverity.java File compiler/java/com/google/dart/compiler/ErrorSeverity.java (right): https://chromiumcodereview.appspot.com/10627017/diff/1/compiler/java/com/google/dart/compiler/ErrorSeverity.java#newcode1 compiler/java/com/google/dart/compiler/ErrorSeverity.java:1: package com.google.dart.compiler; nit: missing copyright

8 years, 6 months ago (2012-06-22 13:50:04 UTC) #2

LGTM

Expand Messages | Collapse Messages