Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: src/debug.cc

Issue 10627015: Actually put debug information on stack when aborting. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 67d47c04e06373051b508f2e41c5051e5e2fe088..668e6a186344d402ec2a53d74fadfb0bad2c01f0 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -896,8 +896,18 @@ void Debug::PutValuesOnStackAndDie(int start,
Address c_entry_fp,
Address last_fp,
Address larger_fp,
+ Address last_in_fp,
+ Address last_out_fp,
int count,
int end) {
+ OS::PrintError("start: %d\n", start);
+ OS::PrintError("c_entry_fp: %p\n", static_cast<void*>(c_entry_fp));
+ OS::PrintError("last_fp: %p\n", static_cast<void*>(last_fp));
+ OS::PrintError("larger_fp: %p\n", static_cast<void*>(larger_fp));
+ OS::PrintError("last_in_fp: %p\n", static_cast<void*>(last_in_fp));
+ OS::PrintError("last_out_fp: %p\n", static_cast<void*>(last_out_fp));
+ OS::PrintError("count: %d\n", count);
+ OS::PrintError("end: %d\n", end);
OS::Abort();
}
@@ -1010,6 +1020,8 @@ Object* Debug::Break(Arguments args) {
frame->fp(),
thread_local_.last_fp_,
NULL,
+ thread_local_.step_into_fp_,
+ thread_local_.step_out_fp_,
count,
0xFEEEEEEE);
} else if (it.frame()->fp() != thread_local_.last_fp_) {
@@ -1018,6 +1030,8 @@ Object* Debug::Break(Arguments args) {
frame->fp(),
thread_local_.last_fp_,
it.frame()->fp(),
+ thread_local_.step_into_fp_,
+ thread_local_.step_out_fp_,
count,
0xFEEEEEEE);
}
« no previous file with comments | « src/debug.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698