Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: tools/testing/dart/browser_test.dart

Issue 10627004: Listen for on.error events in test_controller.js (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: addressing comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/unittest/test_controller.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_test.dart
diff --git a/tools/testing/dart/browser_test.dart b/tools/testing/dart/browser_test.dart
index b3cd1c2c8d03b26277f44e579631e21df1c84ca7..f7dccc21a67413fcdbd9fab73b482d8108aec445 100644
--- a/tools/testing/dart/browser_test.dart
+++ b/tools/testing/dart/browser_test.dart
@@ -22,31 +22,6 @@ String GetHtmlContents(String title,
<body>
<h1> Running $title </h1>
<script type="text/javascript" src="$controllerScript"></script>
- <script type="text/javascript">
- // If nobody intercepts the error, finish the test.
- onerror = function(message, url, lineNumber) {
- if (window.layoutTestController) {
- window.layoutTestController.notifyDone();
- }
- };
-
- document.onreadystatechange = function() {
- if (document.readyState != "loaded") return;
- // If 'startedDartTest' is not set, that means that the test did not have
- // a chance to load. This will happen when a load error occurs in the VM.
- // Give the machine time to start up.
- setTimeout(function() {
- // A window.postMessage might have been enqueued after this timeout.
- // Just sleep another time to give the browser the time to process the
- // posted message.
- setTimeout(function() {
- if (layoutTestController && !layoutTestController.startedDartTest) {
- layoutTestController.notifyDone();
- }
- }, 0);
- }, 50);
- };
- </script>
<script type="$scriptType" src="$sourceScript"></script>
</body>
</html>
« no previous file with comments | « lib/unittest/test_controller.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698