content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java - Issue 10626017: Provide a common interface for all Android app resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java

Issue 10626017: Provide a common interface for all Android app resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/org/chromium/content/app/AppResource.java ('K') | « content/public/android/java/org/chromium/content/browser/ContentView.java ('k') | content/shell/android/res/values/dimens.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java

diff --git a/content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java b/content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java

index 4f6c8f724a695893bd6a62e0aa072b2388625eec..df997d06d84b82f1c5cc92a665442e8d13e23a4e 100644

--- a/content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java

+++ b/content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java

@@ -11,6 +11,7 @@ import android.text.TextUtils;

import android.util.Log;

import android.view.KeyEvent;

+import org.chromium.content.app.AppResource;

import org.chromium.content.app.LibraryLoader;

import org.chromium.content.browser.ContentView;

import org.chromium.content.common.CommandLine;

@@ -98,7 +99,7 @@ public class ContentShellActivity extends Activity {

}

private void initializeContentViewResources() {

- ContentView.registerPopupOverlayCornerRadius(0);

- ContentView.registerPopupOverlayResourceId(R.drawable.popup_zoomer_overlay);

+ AppResource.DRAWABLE_LINK_PREVIEW_POPUP_OVERLAY = R.drawable.popup_zoomer_overlay;

+ AppResource.DIMENSION_LINK_PREVIEW_OVERLAY_RADIUS = R.dimen.link_preview_overlay_radius;

bulach 2012/06/22 15:00:56 nit: maybe keep this sorted (DIMENSION prior to DR

Leandro Graciá Gil 2012/06/22 15:11:59 Done.

}