Provide a common interface for all Android app resources.

Provide a common interface for all Android app resources.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143909

[bulach, 2012-06-22 15:00:56]

lgtm (but you'll need OWNERs approval for content/shell/android..)

just some nits:

https://chromiumcodereview.appspot.com/10626017/diff/1/content/public/android...
File content/public/android/java/org/chromium/content/app/AppResource.java
(right):

https://chromiumcodereview.appspot.com/10626017/diff/1/content/public/android...
content/public/android/java/org/chromium/content/app/AppResource.java:12: * All
resources must be registered before instantiating ContentView objects.
we should probably remove all the resources that aren't being registered yet? :)

https://chromiumcodereview.appspot.com/10626017/diff/1/content/shell/android/...
File
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java
(right):

https://chromiumcodereview.appspot.com/10626017/diff/1/content/shell/android/...
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java:103:
AppResource.DIMENSION_LINK_PREVIEW_OVERLAY_RADIUS =
R.dimen.link_preview_overlay_radius;
nit: maybe keep this sorted (DIMENSION prior to DRAWABLE)

[Leandro Graciá Gil, 2012-06-22 15:11:59]

https://chromiumcodereview.appspot.com/10626017/diff/1/content/public/android...
File content/public/android/java/org/chromium/content/app/AppResource.java
(right):

https://chromiumcodereview.appspot.com/10626017/diff/1/content/public/android...
content/public/android/java/org/chromium/content/app/AppResource.java:12: * All
resources must be registered before instantiating ContentView objects.
On 2012/06/22 15:00:56, bulach wrote:
> we should probably remove all the resources that aren't being registered yet?
:)

Done.

https://chromiumcodereview.appspot.com/10626017/diff/1/content/shell/android/...
File
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java
(right):

https://chromiumcodereview.appspot.com/10626017/diff/1/content/shell/android/...
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java:103:
AppResource.DIMENSION_LINK_PREVIEW_OVERLAY_RADIUS =
R.dimen.link_preview_overlay_radius;
On 2012/06/22 15:00:56, bulach wrote:
> nit: maybe keep this sorted (DIMENSION prior to DRAWABLE)

Done.

[Ted C, 2012-06-22 17:41:12]

lgtm

[Leandro Graciá Gil, 2012-06-22 17:42:44]

On 2012/06/22 17:41:12, Ted C wrote:
> lgtm

Thanks for the review! Landing soon.

[commit-bot: I haz the power, 2012-06-22 17:46:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/10626017/6001

[commit-bot: I haz the power, 2012-06-22 18:06:34]

Try job failure for 10626017-6001 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[Leandro Graciá Gil, 2012-06-22 18:08:06]

On 2012/06/22 18:06:34, I haz the power (commit-bot) wrote:
> Try job failure for 10626017-6001 (retry) on android for steps "compile,
build"
> (clobber build).
> It's a second try, previously, steps "compile, build" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Interesting... why this didn't happen locally? I'll fix it.

[commit-bot: I haz the power, 2012-06-25 13:51:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/10626017/13001

[commit-bot: I haz the power, 2012-06-25 15:06:47]

Change committed as 143909