Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10626007: Move ExtensionSystem into extensions namespace (Closed)

Created:
8 years, 6 months ago by Devlin
Modified:
8 years, 5 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, ncarter (slow), ben+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), dbeam+watch-ntp_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, Raghu Simha, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, akalin, Aaron Boodman, Satish, rdsmith+dwatch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move ExtensionSystem into extensions namespace BUG=134017, 117261 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146196

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Added ExtensionSystem-related classes to the net #

Patch Set 3 : Latest master merged for cq #

Patch Set 4 : Master merge; moved class declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -189 lines) Patch
M chrome/browser/autocomplete/autocomplete_classifier_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_handler_util.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_management_apitest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 2 3 8 chunks +25 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 2 16 chunks +26 lines, -27 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/platform_app_launcher.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/script_badge_controller.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 2 4 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/speech/speech_input_extension_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/app_list/extension_app_item.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/panel_view_aura.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/command_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_info_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Devlin
Just a refactor, but touches a few different places. Please review when possible.
8 years, 5 months ago (2012-07-03 21:54:06 UTC) #1
Peter Kasting
When you specify multiple reviewers, you need to say precisely what you expect each to ...
8 years, 5 months ago (2012-07-03 22:09:26 UTC) #2
akalin
assuming I'm on this review for sync stuff, sync lgtm
8 years, 5 months ago (2012-07-03 22:15:03 UTC) #3
Devlin
On 2012/07/03 22:09:26, Peter Kasting wrote: > When you specify multiple reviewers, you need to ...
8 years, 5 months ago (2012-07-03 22:15:08 UTC) #4
Peter Kasting
chrome/browser/ui LGTM
8 years, 5 months ago (2012-07-03 22:19:18 UTC) #5
Aaron Boodman
c/b/e lgtm https://chromiumcodereview.appspot.com/10626007/diff/12057/chrome/browser/extensions/extension_system.h File chrome/browser/extensions/extension_system.h (left): https://chromiumcodereview.appspot.com/10626007/diff/12057/chrome/browser/extensions/extension_system.h#oldcode64 chrome/browser/extensions/extension_system.h:64: virtual extensions::ManagementPolicy* management_policy() = 0; yay! https://chromiumcodereview.appspot.com/10626007/diff/12057/chrome/browser/extensions/extension_system_factory.h ...
8 years, 5 months ago (2012-07-03 23:40:54 UTC) #6
akalin
c/b/s lgtm
8 years, 5 months ago (2012-07-11 01:45:42 UTC) #7
sail
profiles/* cocoa/* LGTM!
8 years, 5 months ago (2012-07-11 17:14:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10626007/17004
8 years, 5 months ago (2012-07-11 17:51:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10626007/13060
8 years, 5 months ago (2012-07-11 19:07:23 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 20:44:02 UTC) #11 
Change committed as 146196

Powered by Google App Engine
This is Rietveld 408576698