Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Issue 10626005: Add lots of 2x assets (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, dcheng, Aaron Boodman, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Add lots of 2x assets Move a few 1x assets to the default_100_percent folder. BUG=132910 TEST=Look at various icons. More HiDPI. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143476

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-83 lines, --83 lines) Patch
D chrome/app/theme/about_conflicts.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/bookmark_bar_folder_mac.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_100_percent/about_conflicts.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/bookmark_bar_folder_mac.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/extensions_section.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/fullscreen_menu_button.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/sadtab.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/about_conflicts.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/accessed_cookies.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/alert_small.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/app_default_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/app_droparrow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/back_large.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/bookmark_bar_folder_mac.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_extension.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_extension_gray.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_extension_large.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_mandatory.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_mandatory_gray.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_mandatory_large.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_recommended.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_recommended_gray.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/controlled_setting_recommended_large.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/cookie.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/cookie_storage.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/cws_star_empty.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/cws_star_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/cws_star_half.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/download_animation_begin.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/download_progress_background16.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/download_progress_background32.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/download_progress_foreground16.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/download_progress_foreground32.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/extension_command_close.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/extension_default_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/extensions_rating_star_half_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/extensions_rating_star_half_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/extensions_rating_star_off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/extensions_rating_star_on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/extensions_section.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/forward_large.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/frozen_tab.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/fullscreen_menu_button.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/geolocation_allowed_locationbar_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/geolocation_denied_locationbar_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/info_small.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/input_alert.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/input_good.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/keyword_hint_tab_mac.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/nub.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/pageinfo_bad.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/pageinfo_good.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/pageinfo_info.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/pageinfo_warning_major.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/pageinfo_warning_minor.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_close.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_close_click.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_close_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_minimize.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_minimize_click.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_minimize_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_restore.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_restore_click.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/panel_restore_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/protector_home_alert.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/protector_home_badge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/protector_home_menu.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/protector_search_alert.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/protector_search_badge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/protector_search_menu.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/sadtab.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/safebrowsing_warning.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/small_bubble.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_mic_empty.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_mic_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_mic_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_mic_noise.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_spinner.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_tray_balloon_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_tray_linux_mic_empty.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_tray_linux_mic_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_tray_macosx_mic_empty.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_tray_macosx_mic_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_tray_windows_mic_empty.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/speech_input_tray_windows_mic_full.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_available.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_badge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_badge2.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_badge3.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_badge4.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_fail.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_menu.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_menu2.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_menu3.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/update_menu4.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/extensions_section.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/fullscreen_menu_button.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/sadtab.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/css/bmm.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/wrench_menu.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/crashes.css View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/resources/incognito_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugins.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
8 years, 6 months ago (2012-06-21 21:09:50 UTC) #1
Avi (use Gerrit)
Comments: - So we're leaving it to ben to merge the grd files, then. - ...
8 years, 6 months ago (2012-06-21 21:17:17 UTC) #2
flackr
http://codereview.chromium.org/10626005/diff/10003/chrome/browser/resources/crashes.css File chrome/browser/resources/crashes.css (right): http://codereview.chromium.org/10626005/diff/10003/chrome/browser/resources/crashes.css#newcode12 chrome/browser/resources/crashes.css:12: background-image: url('../../app/theme/default_100_percent/sadtab.png'); For this and other assets where a ...
8 years, 6 months ago (2012-06-21 21:19:21 UTC) #3
Nico
On 2012/06/21 21:17:17, Avi wrote: > Comments: > > - So we're leaving it to ...
8 years, 6 months ago (2012-06-21 22:15:18 UTC) #4
Avi (use Gerrit)
SGTM. LGTM.
8 years, 6 months ago (2012-06-21 22:17:54 UTC) #5
flackr
On 2012/06/21 22:15:18, Nico wrote: > On 2012/06/21 21:17:17, Avi wrote: > > Comments: > ...
8 years, 6 months ago (2012-06-21 22:25:49 UTC) #6
James Hawkins
8 years, 6 months ago (2012-06-21 22:38:18 UTC) #7
Rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698