Cleaning up usage of lookup results.

Cleaning up usage of lookup results.

- Ensure that IsFound() is only used when not in combination with other
  checks. To do so, the default type is NONEXISTENT rather than NORMAL;
  and NotFound() also resets the type to NONEXISTENT.
- Use test methods rather than .type() == A_PROPERTY_TYPE.

Committed: https://code.google.com/p/v8/source/detail?r=11899

[Toon Verwaest, 2012-06-21 14:20:32]

PTAL.

This is a step towards weeding out the differences between descriptors /
transitions / handlers and interceptors.

[danno, 2012-06-21 14:34:30]

LGTM if you beef up your internal checking of state with some asserts.

https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h
File src/property.h (right):

https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode269
src/property.h:269: bool IsFastPropertyType() { return type() != NORMAL; }
Add asserts for (IsFound());

https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode271
src/property.h:271: bool IsCallbacks() { return details_.type() == CALLBACKS; }
Add asserts for (IsFound());

https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode278
src/property.h:278: bool IsField() { return details_.type() == FIELD; }
Add asserts for (IsFound());

https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode279
src/property.h:279: bool IsNormal() { return details_.type() == NORMAL; }
Add asserts for (IsFound());

https://chromiumcodereview.appspot.com/10626004/diff/1/src/property.h#newcode280
src/property.h:280: bool IsConstantFunction() { return details_.type() ==
CONSTANT_FUNCTION; }
Add asserts for (IsFound());