chrome power profiler chrome side changes

content/public/browser/power_profiler_service.h

Index: content/public/browser/power_profiler_service.h
diff --git a/content/public/browser/power_profiler_service.h b/content/public/browser/power_profiler_service.h
new file mode 100644
index 0000000000000000000000000000000000000000..c465f62df379fc3ea3e458eaffc61eec234b8ac5
--- /dev/null
+++ b/content/public/browser/power_profiler_service.h
@@ -0,0 +1,69 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_POWER_PROFILER_SERVICE_H_
+#define CONTENT_PUBLIC_BROWSER_POWER_PROFILER_SERVICE_H_
+
+#include <set>
+
+#include "base/basictypes.h"
+#include "base/memory/singleton.h"
+#include "base/task_runner.h"
+#include "base/timer/timer.h"
+#include "content/common/content_export.h"
+#include "content/public/browser/power_data_provider.h"
+#include "content/public/browser/power_profiler_observer.h"
+
+namespace content {
+
+// A class used to monitor the power usage and tell profiler the power data
+class CONTENT_EXPORT PowerProfilerService {
+ public:
+  static PowerProfilerService* GetInstance();
+
+  // Add and remove an observer.
+  void AddObserver(PowerProfilerObserver* observer);
+  void RemoveObserver(PowerProfilerObserver* observer);
+  void UpdateResolution();
+
+  bool IsAvailable() { return status_ !=  UNINITIALIZED; }

[qsr, 2014/01/22 15:30:01]

This is not a simple getter, so should not be inlined.

+
+ private:
+  enum Status {
+    UNINITIALIZED, // Unitialized,
+    INITIALIZED, // Initialized, not in profiling
+    PROFILING, // In profiling
+  };
+
+  friend struct DefaultSingletonTraits<PowerProfilerService>;
+
+  PowerProfilerService();
+  virtual ~PowerProfilerService();
+
+  void Start();
+  void Stop();
+
+  void OnTimer();
+  void InitializeDelays();
+
+  // ProcessData and Notify are delegated to thread in WorkerPool
+  void ProcessData();
+  void Notify(PowerEvent* event);
+
+  base::RepeatingTimer<PowerProfilerService> query_power_timer_;
+  scoped_refptr<base::TaskRunner> task_runner_;
+
+  size_t delay_; // milliseconds

[qsr, 2014/01/22 15:30:01]

Use directly a base::TimeTicks

+  size_t delays_[PowerProfilerObserver::TYPE_COUNT]; // kinds of delays

[qsr, 2014/01/22 15:30:01]

Same here.

+  Status status_;
+  std::set<PowerProfilerObserver* > observers_;

[qsr, 2014/01/22 15:30:01]

Use base/observer_list.h

+
+  scoped_ptr<PowerDataProvider> data_provider_;
+
+  DISALLOW_COPY_AND_ASSIGN(PowerProfilerService);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_POWER_PROFILER_SERVICE_H_