chromeos: Stop checking out Libcros

chromeos: Stop checking out Libcros

BUG=127051
TEST=git try -c -b linux_chromeos,cros_x86


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143873

[hashimoto, 2012-06-21 06:54:53]

This change depends on http://codereview.chromium.org/10617004/

[hashimoto, 2012-06-21 07:50:08]

On 2012/06/21 06:54:53, hashimoto wrote:
> This change depends on http://codereview.chromium.org/10617004/
Sorry, 10617004 is wrong, URL for the correct change:
http://codereview.chromium.org/10614003/

[satorux1, 2012-06-21 14:58:39]

LGTM.

BTW, could you remove some code from chromeos-chrome-9999.ebuild too?

http://git.chromium.org/gitweb/?p=chromiumos/overlays/chromiumos-overlay.git;...

1032         # Create copy of chromeos_cros_api.h file so that test_build_root
can check for
1033         # libcros compatibility.
1034         insinto "${CHROME_DIR}"/include
1035         doins "${CHROME_ROOT}/src/third_party/cros/chromeos_cros_api.h"

the libcros check in test_build_root seems to be gone now
(https://gerrit.chromium.org/gerrit/#change,18247), so we don't have to worry
about it.

[hashimoto, 2012-06-22 06:40:19]

On 2012/06/21 14:58:39, satorux1 wrote:
> LGTM.
> 
> BTW, could you remove some code from chromeos-chrome-9999.ebuild too?
> 
>
http://git.chromium.org/gitweb/?p=chromiumos/overlays/chromiumos-overlay.git;...
> 
> 1032         # Create copy of chromeos_cros_api.h file so that test_build_root
> can check for
> 1033         # libcros compatibility.
> 1034         insinto "${CHROME_DIR}"/include
> 1035         doins "${CHROME_ROOT}/src/third_party/cros/chromeos_cros_api.h"
> 
> the libcros check in test_build_root seems to be gone now
> (https://gerrit.chromium.org/gerrit/#change%2C18247), so we don't have to
worry
> about it.

Made a change, please take a look.
https://gerrit.chromium.org/gerrit/#change,25912

[commit-bot: I haz the power, 2012-06-22 09:57:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10621002/6001

[commit-bot: I haz the power, 2012-06-22 09:57:45]

Presubmit check for 10621002-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash

[hashimoto, 2012-06-22 09:59:51]

Ben, could you review ash/DEPS?

[Ben Goodger (Google), 2012-06-22 15:52:52]

lgtm

[commit-bot: I haz the power, 2012-06-25 02:53:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10621002/6001

[commit-bot: I haz the power, 2012-06-25 03:58:09]

Change committed as 143873