Issue 106163008: Move build/build_config_functions.h to sandbox/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106163008: Move build/build_config_functions.h to sandbox/ (Closed)

Created:
7 years ago by jln (very slow on Chromium)

Modified:
7 years ago

Reviewers:
jww

CC:
chromium-reviews, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move build/build_config_functions.h to sandbox/ There is not much support for build/build_config_functions.h, as highlighted in http://goo.gl/3ufXOJ. Move it away. R=jww@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239102

Patch Set 1 : #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -145 lines)			Patch
M	build/build_config.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	build/build_config_functions.h	View	1 chunk	+0 lines, -110 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/bpf_tests.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	sandbox/linux/services/build_config_functions.h	View	3 chunks	+5 lines, -29 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

Robert, please take a look (send to CQ if you're happy with it)

7 years ago (2013-12-06 01:48:28 UTC) #1

jww

lgtm, with nits. https://codereview.chromium.org/106163008/diff/20001/sandbox/linux/services/build_config_functions.h File sandbox/linux/services/build_config_functions.h (left): https://codereview.chromium.org/106163008/diff/20001/sandbox/linux/services/build_config_functions.h#oldcode50 sandbox/linux/services/build_config_functions.h:50: inline bool IsPOSIX() { I assume ...

7 years ago (2013-12-06 01:56:58 UTC) #2

jln (very slow on Chromium)

7 years ago (2013-12-06 01:58:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r239102 (presubmit successful).

Expand Messages | Collapse Messages