Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 10614003: chromeos: Stop depending on Libcros (Closed)

Created:
8 years, 6 months ago by hashimoto
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

chromeos: Stop depending on Libcros BUG=127051 TEST=build success Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143556

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -17 lines 2 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
8 years, 6 months ago (2012-06-21 06:21:11 UTC) #1
satorux1
LGTM
8 years, 6 months ago (2012-06-21 14:36:11 UTC) #2
stevenjb (google-dont-use)
lgtm http://codereview.chromium.org/10614003/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (left): http://codereview.chromium.org/10614003/diff/1/chrome/chrome_browser.gypi#oldcode5072 chrome/chrome_browser.gypi:5072: '../third_party/' I assume we don't need this for ...
8 years, 6 months ago (2012-06-21 16:33:56 UTC) #3
stevenjb
lgtm
8 years, 6 months ago (2012-06-21 16:37:57 UTC) #4
hashimoto
https://chromiumcodereview.appspot.com/10614003/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (left): https://chromiumcodereview.appspot.com/10614003/diff/1/chrome/chrome_browser.gypi#oldcode5072 chrome/chrome_browser.gypi:5072: '../third_party/' On 2012/06/21 16:33:56, stevenjb1 wrote: > I assume ...
8 years, 6 months ago (2012-06-22 05:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10614003/1
8 years, 6 months ago (2012-06-22 05:46:43 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 07:22:44 UTC) #7
Change committed as 143556

Powered by Google App Engine
This is Rietveld 408576698