Chromium Code Reviews| Index: lib/dom/templates/html/frog/impl_Window.darttemplate |
| diff --git a/lib/dom/templates/html/frog/impl_Window.darttemplate b/lib/dom/templates/html/frog/impl_Window.darttemplate |
| index af67edba004acb8ab5b4dfb434cceca85334fdd8..e97ecb66207b262dfff92a08609272ded587830d 100644 |
| --- a/lib/dom/templates/html/frog/impl_Window.darttemplate |
| +++ b/lib/dom/templates/html/frog/impl_Window.darttemplate |
| @@ -11,6 +11,17 @@ class $CLASSNAME$EXTENDS$IMPLEMENTS native "@*DOMWindow" { |
| // Override top to return secure wrapper. |
| Window get top() => _DOMWindowCrossFrameImpl._createSafe(_top); |
| + Window _open2(url, name) native "return this.open(url, name);"; |
| + |
| + Window _open3(url, name, options) native "return this.open(url, name, options);"; |
|
sra1
2012/06/21 16:18:01
For consistency, put the main API (open) first and
|
| + |
| + Window open(String url, String name, [String options]) { |
| + if (options == null) { |
| + return _DOMWindowCrossFrameImpl._createSafe(_open2(url, name)); |
| + } else { |
| + return _DOMWindowCrossFrameImpl._createSafe(_open3(url, name, options)); |
| + } |
| + } |
| // API level getter and setter for Location. |
| // TODO: The cross domain safe wrapper can be inserted here or folded into |