webkit/chromeos/fileapi/remote_file_system_operation.cc - Issue 10600013: Wired support for file truncating with RemoteFileSystemOperation::OpenFile() method (case when base…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/chromeos/fileapi/remote_file_system_operation.cc

Issue 10600013: Wired support for file truncating with RemoteFileSystemOperation::OpenFile() method (case when base… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/file_browser/filehandler_create/test.js ('k') | webkit/chromeos/fileapi/remote_file_system_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/chromeos/fileapi/remote_file_system_operation.cc

diff --git a/webkit/chromeos/fileapi/remote_file_system_operation.cc b/webkit/chromeos/fileapi/remote_file_system_operation.cc

index f90aae968cc17b5fe96760107ac48fbc1b0ec27d..40fc7093b186cc620bc791759d110ab2b5921354 100644

--- a/webkit/chromeos/fileapi/remote_file_system_operation.cc

+++ b/webkit/chromeos/fileapi/remote_file_system_operation.cc

@@ -157,16 +157,6 @@ void RemoteFileSystemOperation::OpenFile(const FileSystemURL& url,

int file_flags,

base::ProcessHandle peer_handle,

const OpenFileCallback& callback) {

- // TODO(zelidrag): Implement file write operations.

- if ((file_flags & base::PLATFORM_FILE_CREATE) ||

- (file_flags & base::PLATFORM_FILE_WRITE) ||

- (file_flags & base::PLATFORM_FILE_EXCLUSIVE_WRITE) ||

- (file_flags & base::PLATFORM_FILE_CREATE_ALWAYS) ||

- (file_flags & base::PLATFORM_FILE_OPEN_TRUNCATED) ||

- (file_flags & base::PLATFORM_FILE_DELETE_ON_CLOSE)) {

- NOTIMPLEMENTED() << "File write operations not supported " << url.spec();

- return;

- }

DCHECK(SetPendingOperationType(kOperationOpenFile));

remote_proxy_->OpenFile(

url,