Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: lib/unittest/core_matchers.dart

Issue 10600003: Type cast fix. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/core_matchers.dart
===================================================================
--- lib/unittest/core_matchers.dart (revision 8951)
+++ lib/unittest/core_matchers.dart (working copy)
@@ -104,10 +104,11 @@
while (reason == null) {
if (expectedIterator.hasNext()) {
if (actualIterator.hasNext()) {
- reason = matcher(expectedIterator.next(),
+ Description r = matcher(expectedIterator.next(),
actualIterator.next(),
'mismatch at position ${position}',
depth);
+ if (r != null) reason = r.toString();
srdjan 2012/06/21 00:07:33 Why guard it (r != null)? (null).toString() shoul
++position;
} else {
reason = 'shorter than expected';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698