Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 10598004: Revert "Revert 143261 - Upstreaming android tools" (Closed)

Created:
8 years, 6 months ago by Isaac (away)
Modified:
8 years, 6 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert "Revert 143261 - Upstreaming android tools" - fixing permissions and relanding. CQ does not run check_perms apparently. - original review: https://chromiumcodereview.appspot.com/10578032/ - failing bot log: http://build.chromium.org/p/chromium/builders/Linux/builds/26592/steps/check_perms/logs/stdio This reverts commit 1ad94575470ccb61f9a64915638aafac3269a28f. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -3 lines) Patch
A build/android/adb_logcat_monitor.py View 1 chunk +155 lines, -0 lines 0 comments Download
A build/android/adb_logcat_printer.py View 1 chunk +202 lines, -0 lines 0 comments Download
M build/android/cmd_helper.py View 3 chunks +15 lines, -3 lines 0 comments Download
A build/android/device_status_check.py View 1 chunk +120 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Isaac (away)
8 years, 6 months ago (2012-06-20 23:37:08 UTC) #1
Yaron
On 2012/06/20 23:37:08, Isaac wrote: lgtm
8 years, 6 months ago (2012-06-20 23:44:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10598004/1
8 years, 6 months ago (2012-06-20 23:58:12 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-21 01:57:33 UTC) #4
Change committed as 143329

Powered by Google App Engine
This is Rietveld 408576698