Issue 10595002: Protocol Buffer runtime library and 'protoc' plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10595002: Protocol Buffer runtime library and 'protoc' plugin (Closed)

Created:
8 years, 6 months ago by Dan Rice

Modified:
8 years, 6 months ago

Reviewers:
dcarlson, tobyr, jbrosenberg, rchandia

CC:
Ivan Posva, Mads Ager (google), reviews_dartlang.org, kasperl, dgrove

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Protocol Buffer runtime library and 'protoc' plugin BUG= TEST= This is passing tests. Please review.

Patch Set 1 #

Patch Set 2 : Remove file not part of this CL #

Patch Set 3 : Remove dependencies on 'x is int' since it can fail in dart2js #

Patch Set 4 : Varints in UnknownFieldSet can be > 32 bits #

Patch Set 5 : Work around http://code.google.com/p/dart/issues/detail?id=3806 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18915 lines, -4 lines)			Patch
M	lib/fixnum/int32.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/fixnum/int64.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
A	lib/protobuf/plugin/CodeGenerator.dart	View		1 chunk	+54 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/DartFile.dart	View		1 chunk	+123 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/DartHelpers.dart	View		1 chunk	+93 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/EnumGenerator.dart	View		1 chunk	+127 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/ExtensionGenerator.dart	View		1 chunk	+115 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/IndentingWriter.dart	View		1 chunk	+87 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/MessageGenerator.dart	View		1 chunk	+311 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/ProtoGenDartConfig.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/ProtobufField.dart	View		1 chunk	+446 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/ProtocException.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/ProtocGenDart.dart	View		1 chunk	+90 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/README	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/Writer.dart	View		1 chunk	+47 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/descriptor.proto	View		1 chunk	+538 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/plugin.proto	View		1 chunk	+145 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/protoc-gen-dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/protoc/descriptor.pb.dart	View		1 chunk	+1329 lines, -0 lines	0 comments	Download
A	lib/protobuf/plugin/protoc/plugin.pb.dart	View		1 chunk	+149 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/Builder.dart	View	1 2	1 chunk	+1572 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/BuilderInfo.dart	View		1 chunk	+239 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/ByteArrayProvider.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/ByteListUtils.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/ChangeListener.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/CodedBufferReader.dart	View	1 2 3	1 chunk	+153 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/CodedBufferWriter.dart	View		1 chunk	+279 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/CodedReader.dart	View		1 chunk	+67 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/CodedStreamReader.dart	View		1 chunk	+206 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/DynamicBuilder.dart	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/DynamicGeneratedMessage.dart	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/Extension.dart	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/ExtensionRegistry.dart	View		1 chunk	+56 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/FieldInfo.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/GeneratedMessage.dart	View	1 2	1 chunk	+776 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/ImmutableList.dart	View		1 chunk	+151 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/ListIntProvider.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/Message.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/PbByteBuffer.dart	View	1 2 3 4	1 chunk	+147 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/PbCodec.dart	View	1 2	1 chunk	+1148 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/PbException.dart	View		1 chunk	+86 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/PbImmutableList.dart	View		1 chunk	+151 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/PbInputStreamReader.dart	View		1 chunk	+116 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/PbList.dart	View	1 2	1 chunk	+409 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/PbReader.dart	View		1 chunk	+63 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/Protobuf.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/ProtobufEnum.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/Protobuf_client.dart	View	1 2	1 chunk	+34 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/UnknownFieldSet.dart	View	1 2 3	1 chunk	+554 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/WireFormat.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	lib/protobuf/runtime/mock_io.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/lib/protobuf/protobuf_client_test.dart	View	1 2 3	1 chunk	+1763 lines, -0 lines	0 comments	Download
A	tests/lib/protobuf/test_util.dart	View		1 chunk	+2381 lines, -0 lines	0 comments	Download
A	tests/lib/protobuf/unittest.proto	View		1 chunk	+630 lines, -0 lines	0 comments	Download
A	tests/lib/protobuf/unittest.pb.dart	View		1 chunk	+3763 lines, -0 lines	0 comments	Download
A	tests/lib/protobuf/unittest_import.proto	View		1 chunk	+60 lines, -0 lines	0 comments	Download
A	tests/lib/protobuf/unittest_import.pb.dart	View		1 chunk	+77 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

This is passing tests.  Please review.

Expand Messages | Collapse Messages