Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: runtime/vm/object_test.cc

Issue 10594002: More ICData cleanups: try to use ICData instead of converting it to another intermediate representa… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 8871)
+++ runtime/vm/object_test.cc (working copy)
@@ -2591,9 +2591,7 @@
EXPECT_EQ(target_name.raw(), o1.target_name());
const Function& target1 = Function::Handle(GetDummyTarget("Thun"));
- GrowableArray<intptr_t> classes;
- classes.Add(kSmi);
- o1.AddCheck(classes, target1);
+ o1.AddReceiverCheck(kSmi, target1);
EXPECT_EQ(1, o1.NumberOfChecks());
intptr_t test_class_id = -1;
Function& test_target = Function::Handle();
@@ -2606,10 +2604,8 @@
EXPECT_EQ(kSmi, test_class_ids[0]);
EXPECT_EQ(target1.raw(), test_target.raw());
- classes.Clear();
const Function& target2 = Function::Handle(GetDummyTarget("Thun"));
- classes.Add(kDouble);
- o1.AddCheck(classes, target2);
+ o1.AddReceiverCheck(kDouble, target2);
EXPECT_EQ(2, o1.NumberOfChecks());
o1.GetOneClassCheckAt(1, &test_class_id, &test_target);
EXPECT_EQ(kDouble, test_class_id);
@@ -2621,7 +2617,7 @@
EXPECT_EQ(57, o2.id());
EXPECT_EQ(function.raw(), o2.function());
EXPECT_EQ(0, o2.NumberOfChecks());
- classes.Clear();
+ GrowableArray<intptr_t> classes;
classes.Add(kSmi);
classes.Add(kSmi);
o2.AddCheck(classes, target1);
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698