More ICData cleanups: try to use ICData instead of converting it to another intermediate representa…

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 178 matching lines @@
   ASSERT(obj == result);
 }
 
 
 LocationSummary* EqualityCompareComp::MakeLocationSummary() const {
   const LocationSummary::ContainsBranch contains_branch =
       is_fused_with_branch() ? LocationSummary::kBranch
                              : LocationSummary::kNoBranch;
 
   const intptr_t kNumInputs = 2;
-  if ((NumTargets() == 1) && (ClassIdAt(0) == kSmi)) {
+  if (HasICData() &&
+      (ic_data()->NumberOfChecks() == 1) &&
+      (ic_data()->GetReceiverClassIdAt(0) == kSmi)) {
     const intptr_t kNumTemps = 1;
     LocationSummary* locs = new LocationSummary(kNumInputs,
                                                 kNumTemps,
                                                 LocationSummary::kNoCall,
                                                 contains_branch);
     locs->set_in(0, Location::RequiresRegister());
     locs->set_in(1, Location::RequiresRegister());
     locs->set_temp(0, Location::RequiresRegister());
     if (!is_fused_with_branch()) {
       locs->set_out(Location::RequiresRegister());
     }
     return locs;
   }
-  if (NumTargets() > 0) {
+  if (HasICData() && (ic_data()->NumberOfChecks() > 0)) {
     const intptr_t kNumTemps = 1;
     LocationSummary* locs = new LocationSummary(kNumInputs,
                                                 kNumTemps,
                                                 LocationSummary::kCall,
                                                 contains_branch);
     locs->set_in(0, Location::RequiresRegister());
     locs->set_in(1, Location::RequiresRegister());
     locs->set_temp(0, Location::RequiresRegister());
     if (!is_fused_with_branch()) {
       locs->set_out(Location::RegisterLocation(EAX));
@@ skipping 70 matching lines @@
     __ CompareObject(EAX, compiler->bool_true());
     comp->fused_with_branch()->EmitBranchOnCondition(compiler, EQUAL);
   }
 }
 
 
 static void EmitEqualityAsPolymorphicCall(FlowGraphCompiler* compiler,
                                           EqualityCompareComp* comp,
                                           Register left,
                                           Register right) {
-  ASSERT(comp->NumTargets() > 0);
+  ASSERT(comp->HasICData());
+  const ICData& ic_data = *comp->ic_data();
+  ASSERT(ic_data.NumberOfChecks() > 0);
   Label* deopt = compiler->AddDeoptStub(comp->cid(),
                                         comp->token_index(),
                                         comp->try_index(),
                                         kDeoptEquality);
   __ testl(left, Immediate(kSmiTagMask));
   Register temp = comp->locs()->temp(0).reg();
-  if (comp->ClassIdAt(0) == kSmi) {
+  if (ic_data.GetReceiverClassIdAt(0) == kSmi) {
     Label done, load_class_id;
     __ j(NOT_ZERO, &load_class_id, Assembler::kNearJump);
     __ movl(temp, Immediate(kSmi));
     __ jmp(&done, Assembler::kNearJump);
     __ Bind(&load_class_id);
     __ LoadClassId(temp, left);
     __ Bind(&done);
   } else {
     __ j(ZERO, deopt);  // Smi deopts.
     __ LoadClassId(temp, left);
   }
   Label done;
-  for (intptr_t i = 0; i < comp->NumTargets(); i++) {
-    ASSERT((comp->ClassIdAt(i) != kSmi) || (i == 0));
+  for (intptr_t i = 0; i < ic_data.NumberOfChecks(); i++) {
+    ASSERT((ic_data.GetReceiverClassIdAt(i) != kSmi) || (i == 0));
     Label next_test;
-    __ cmpl(temp, Immediate(comp->ClassIdAt(i)));
+    __ cmpl(temp, Immediate(ic_data.GetReceiverClassIdAt(i)));
     __ j(NOT_EQUAL, &next_test, Assembler::kNearJump);
-    const Function& target = *comp->TargetAt(i);
+    const Function& target = Function::ZoneHandle(ic_data.GetTargetAt(i));
     ObjectStore* object_store = Isolate::Current()->object_store();
     if (target.owner() == object_store->object_class()) {
       // Object.== is same as ===.
       __ Drop(2);
       __ cmpl(left, right);
       if (comp->is_fused_with_branch()) {
         comp->fused_with_branch()->EmitBranchOnCondition(compiler, EQUAL);
       } else {
         // This case should be rare.
         Register result = comp->locs()->out().reg();
@@ skipping 52 matching lines @@
     __ LoadObject(result, compiler->bool_false());
     __ jmp(&done);
     __ Bind(&load_true);
     __ LoadObject(result, compiler->bool_true());
   }
   __ jmp(&done);
 
   __ Bind(&non_null_compare);  // Receiver is not null.
   __ pushl(left);
   __ pushl(right);
-  if (comp->NumTargets() > 0) {
+  if (comp->HasICData() && (comp->ic_data()->NumberOfChecks() > 0)) {
     EmitEqualityAsPolymorphicCall(compiler, comp, left, right);
   } else {
     EmitEqualityAsInstanceCall(compiler, comp);
   }
   __ Bind(&done);
 }
 
 
 void EqualityCompareComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  if ((NumTargets() == 1) && (ClassIdAt(0) == kSmi)) {
+  if (HasICData() &&
+      (ic_data()->NumberOfChecks() == 1) &&
+      (ic_data()->GetReceiverClassIdAt(0) == kSmi)) {
     EmitSmiEqualityCompare(compiler, this);
     return;
   }
   EmitGenericEqualityCompare(compiler, this);
 }
 
 
 LocationSummary* RelationalOpComp::MakeLocationSummary() const {
   const LocationSummary::ContainsBranch contains_branch =
       is_fused_with_branch() ? LocationSummary::kBranch
@@ skipping 425 matching lines @@
 LocationSummary* LoadInstanceFieldComp::MakeLocationSummary() const {
   // TODO(fschneider): For this instruction the input register may be
   // reused for the result (but is not required to) because the input
   // is not used after the result is defined.  We should consider adding
   // this information to the input policy.
   return LocationSummary::Make(1, Location::RequiresRegister());
 }
 
 
 void LoadInstanceFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  Register instance = locs()->in(0).reg();
-  Register result = locs()->out().reg();
+  Register instance_reg = locs()->in(0).reg();
+  Register result_reg = locs()->out().reg();
 
-  if (class_ids() != NULL) {
+  if (HasICData()) {
     ASSERT(original() != NULL);
     Label* deopt = compiler->AddDeoptStub(original()->cid(),
                                           original()->token_index(),
                                           original()->try_index(),
                                           kDeoptInstanceGetterSameTarget,
-                                          instance);
+                                          instance_reg);
     // Smis do not have instance fields (Smi class is always first).
     // Use 'result' as temporary register.
-    ASSERT(result != instance);
-    compiler->EmitClassChecksNoSmi(*class_ids(), instance, result, deopt);
+    ASSERT(result_reg != instance_reg);
+    ASSERT(ic_data() != NULL);
+    compiler->EmitClassChecksNoSmi(*ic_data(), instance_reg, result_reg, deopt);
   }
-  __ movl(result, FieldAddress(instance, field().Offset()));
+  __ movl(result_reg, FieldAddress(instance_reg, field().Offset()));
 }
 
 
 LocationSummary* LoadStaticFieldComp::MakeLocationSummary() const {
   return LocationSummary::Make(0, Location::RequiresRegister());
 }
 
 
 void LoadStaticFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register result = locs()->out().reg();
@@ skipping 94 matching lines @@
   __ popl(result);  // Pop new instance.
 }
 
 
 LocationSummary* LoadVMFieldComp::MakeLocationSummary() const {
   return LocationSummary::Make(1, Location::RequiresRegister());
 }
 
 
 void LoadVMFieldComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  Register instance = locs()->in(0).reg();
-  Register result = locs()->out().reg();
-  if (class_ids() != NULL) {
+  Register instance_reg = locs()->in(0).reg();
+  Register result_reg = locs()->out().reg();
+  if (HasICData()) {
     ASSERT(original() != NULL);
     Label* deopt = compiler->AddDeoptStub(original()->cid(),
                                           original()->token_index(),
                                           original()->try_index(),
                                           kDeoptInstanceGetterSameTarget,
-                                          instance);
+                                          instance_reg);
     // Smis do not have instance fields (Smi class is always first).
     // Use 'result' as temporary register.
-    ASSERT(result != instance);
-    compiler->EmitClassChecksNoSmi(*class_ids(), instance, result, deopt);
+    ASSERT(result_reg != instance_reg);
+    ASSERT(ic_data() != NULL);
+    compiler->EmitClassChecksNoSmi(*ic_data(), instance_reg, result_reg, deopt);
   }
 
-  __ movl(result, FieldAddress(instance, offset_in_bytes()));
+  __ movl(result_reg, FieldAddress(instance_reg, offset_in_bytes()));
 }
 
 
 LocationSummary* InstantiateTypeArgumentsComp::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
   const intptr_t kNumTemps = 1;
   LocationSummary* locs = new LocationSummary(kNumInputs,
                                               kNumTemps,
                                               LocationSummary::kCall);
   locs->set_in(0, Location::RequiresRegister());
@@ skipping 729 matching lines @@
 }
 
 
 LocationSummary* PolymorphicInstanceCallComp::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void PolymorphicInstanceCallComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   ASSERT(instance_call()->VerifyComputation());
-  ASSERT(class_ids().length() == targets().length());
-  ASSERT(class_ids().length() > 0);
+  ASSERT(HasICData());
+  ASSERT(ic_data()->num_args_tested() == 1);
   Label* deopt = compiler->AddDeoptStub(instance_call()->cid(),
                                         instance_call()->token_index(),
                                         instance_call()->try_index(),
                                         kDeoptPolymorphicInstanceCallTestFail);
   Label handle_smi;
-  Label* is_smi_label = class_ids()[0] == kSmi ?  &handle_smi : deopt;
+  Label* is_smi_label =
+      ic_data()->GetReceiverClassIdAt(0) == kSmi ?  &handle_smi : deopt;
+
   // Load receiver into EAX.
   __ movl(EAX,
       Address(ESP, (instance_call()->ArgumentCount() - 1) * kWordSize));
   __ testl(EAX, Immediate(kSmiTagMask));
   __ j(ZERO, is_smi_label);
   Label done;
   __ LoadClassId(EDI, EAX);
-  for (intptr_t i = 0; i < class_ids().length(); i++) {
+  for (intptr_t i = 0; i < ic_data()->NumberOfChecks(); i++) {
     Label next_test;
-    __ cmpl(EDI, Immediate(class_ids()[i]));
+    __ cmpl(EDI, Immediate(ic_data()->GetReceiverClassIdAt(i)));
     __ j(NOT_EQUAL, &next_test);
+    const Function& target = Function::ZoneHandle(ic_data()->GetTargetAt(i));
     compiler->GenerateStaticCall(instance_call()->cid(),
                                  instance_call()->token_index(),
                                  instance_call()->try_index(),
-                                 *targets()[i],
+                                 target,
                                  instance_call()->ArgumentCount(),
                                  instance_call()->argument_names());
     __ jmp(&done);
     __ Bind(&next_test);
   }
   __ jmp(deopt);
   if (is_smi_label == &handle_smi) {
     __ Bind(&handle_smi);
+    ASSERT(ic_data()->GetReceiverClassIdAt(0) == kSmi);
+    const Function& target = Function::ZoneHandle(ic_data()->GetTargetAt(0));
     compiler->GenerateStaticCall(instance_call()->cid(),
                                  instance_call()->token_index(),
                                  instance_call()->try_index(),
-                                 *targets()[0],
+                                 target,
                                  instance_call()->ArgumentCount(),
                                  instance_call()->argument_names());
   }
   __ Bind(&done);
 }
 
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64