- Fix the barrier code when low bits of Smi are zeroes.

runtime/vm/assembler_ia32_test.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/os.h"
 #include "vm/unit_test.h"
@@ skipping 1844 matching lines @@
                             RawObject* value,
                             RawObject* growable_array);
   StoreData test_code = reinterpret_cast<StoreData>(entry);
 
   const Array& old_array = Array::Handle(Array::New(3, Heap::kOld));
   const Array& new_array = Array::Handle(Array::New(3, Heap::kNew));
   const GrowableObjectArray& grow_old_array = GrowableObjectArray::Handle(
       GrowableObjectArray::New(old_array, Heap::kOld));
   const GrowableObjectArray& grow_new_array = GrowableObjectArray::Handle(
       GrowableObjectArray::New(old_array, Heap::kNew));
-  const Smi& smi = Smi::Handle(Smi::New(7));
+  Smi& smi = Smi::Handle();
   const Context& ctx = Context::Handle(Context::New(0));
 
   EXPECT(old_array.raw() == grow_old_array.data());
   EXPECT(!Isolate::Current()->store_buffer()->Contains(
       reinterpret_cast<uword>(grow_old_array.raw()) +
       GrowableObjectArray::data_offset() - kHeapObjectTag));
   EXPECT(old_array.raw() == grow_new_array.data());
   EXPECT(!Isolate::Current()->store_buffer()->Contains(
       reinterpret_cast<uword>(grow_new_array.raw()) +
       GrowableObjectArray::data_offset() - kHeapObjectTag));
 
-  // Store Smi into the old object.
-  test_code(ctx.raw(), smi.raw(), grow_old_array.raw());
-  EXPECT(reinterpret_cast<RawArray*>(smi.raw()) == grow_old_array.data());
-  EXPECT(!Isolate::Current()->store_buffer()->Contains(
-      reinterpret_cast<uword>(grow_old_array.raw()) +
-      GrowableObjectArray::data_offset() - kHeapObjectTag));
+  // Store Smis into the old object.
+  for (int i = -32; i < 32; i++) {

[cshapiro, 2012/06/20 20:36:11]

You probably want to check all of the values in the range of the test imm8
instruction.

+    smi = Smi::New(i);
+    test_code(ctx.raw(), smi.raw(), grow_old_array.raw());
+    EXPECT(reinterpret_cast<RawArray*>(smi.raw()) == grow_old_array.data());
+    EXPECT(!Isolate::Current()->store_buffer()->Contains(
+        reinterpret_cast<uword>(grow_old_array.raw()) +
+        GrowableObjectArray::data_offset() - kHeapObjectTag));
+  }
 
   // Store an old object into the old object.
   test_code(ctx.raw(), old_array.raw(), grow_old_array.raw());
   EXPECT(old_array.raw() == grow_old_array.data());
   EXPECT(!Isolate::Current()->store_buffer()->Contains(
       reinterpret_cast<uword>(grow_old_array.raw()) +
       GrowableObjectArray::data_offset() - kHeapObjectTag));
 
   // Store a new object into the old object.
   test_code(ctx.raw(), new_array.raw(), grow_old_array.raw());
@@ skipping 14 matching lines @@
   EXPECT(old_array.raw() == grow_new_array.data());
   EXPECT(!Isolate::Current()->store_buffer()->Contains(
       reinterpret_cast<uword>(grow_new_array.raw()) +
       GrowableObjectArray::data_offset() - kHeapObjectTag));
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32