vm/runtime_entry_x64.cc - Issue 10592006: Rework leaf calls as just simple C calls with a signature and not the NativeArgumentDescriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/runtime_entry_x64.cc

Issue 10592006: Rework leaf calls as just simple C calls with a signature and not the NativeArgumentDescriptor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/runtime_entry_x64.cc

===================================================================

--- vm/runtime_entry_x64.cc (revision 8859)

+++ vm/runtime_entry_x64.cc (working copy)

@@ -21,12 +21,13 @@

// RBX : address of the runtime function to call.

// R10 : number of arguments to the call.

void RuntimeEntry::Call(Assembler* assembler) const {

- __ movq(RBX, Immediate(GetEntryPoint()));

- __ movq(R10, Immediate(argument_count()));

- if (is_leaf()) {

- __ call(&StubCode::CallToLeafRuntimeLabel());

+ if (!is_leaf()) {

+ __ movq(RBX, Immediate(GetEntryPoint()));

+ __ movq(R10, Immediate(argument_count()));

+ __ call(&StubCode::CallToRuntimeLabel());

} else {

- __ call(&StubCode::CallToRuntimeLabel());

+ ExternalLabel label(name(), GetEntryPoint());

+ __ call(&label);

}

« no previous file with comments | « vm/runtime_entry_test.cc ('k') | vm/stub_code.h » ('j') | no next file with comments »