Check that the C string passed to Dart_NewString is valid UTF-8.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 1481 matching lines @@
     RETURN_TYPE_ERROR(isolate, str, String);
   }
   *len = str_obj.Length();
   return Api::Success(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_NewString(const char* str) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
+  if (str == NULL) {
+    return Api::NewError("%s expects argument 'str' to be non-null.",

[hausner, 2012/06/20 22:05:25]

You can use the macro CHECK_NOT_NULL() for this.

[cshapiro, 2012/06/20 22:09:06]

This turns out to be part of the debugger API.  I will move this around in a
separate change so the rest of this file can make use of that definition.

+                         CURRENT_FUNC);
+  }
+  if (!Utf8::IsValid(str)) {
+    return Api::NewError("%s expects argument 'str' to be valid UTF-8.",
+                         CURRENT_FUNC);
+  }
   return Api::NewHandle(isolate, String::New(str));
 }
 
 
 DART_EXPORT Dart_Handle Dart_NewString8(const uint8_t* codepoints,
                                         intptr_t length) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   return Api::NewHandle(isolate, String::New(codepoints, length));
 }
@@ skipping 2136 matching lines @@
     *buffer_size = 0;
   }
 }
 
 
 DART_EXPORT void Dart_InitFlowGraphPrinting(FileWriterFunction function) {
   Dart::set_flow_graph_writer(function);
 }
 
 }  // namespace dart