lib/dom/scripts/systemnative.py - Issue 10584031: Proper support for IDL arrays in generators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10584031: Proper support for IDL arrays in generators. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Next iteration Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/dom/scripts/systemnative.py

diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py

index ca0598c60b2b2753d8f60a12a0640dbb5a219951..8bbf266cb1cbd3ff95a605c75d1022522f65c901 100644

--- a/lib/dom/scripts/systemnative.py

+++ b/lib/dom/scripts/systemnative.py

@@ -942,8 +942,7 @@ class NativeImplementationGenerator(systembase.BaseGenerator):

argument_name=None):

"""idl_node is IDLArgument or IDLAttribute."""

type_info = GetIDLTypeInfo(idl_node.type.id)

- if not IsPrimitiveType(idl_node.type.id):

- self._cpp_impl_includes.add('"Dart%s.h"' % type_info.idl_type())

+ self._cpp_impl_includes |= set(type_info.to_native_includes())

argument_name = argument_name or idl_node.id

handle = 'Dart_GetNativeArgument(args, %i)' % index

return type_info.emit_to_native(emitter, idl_node, argument_name, handle, self._interface.id)