Proper support for IDL arrays in generators.

lib/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import copy
 import re
@@ skipping 714 matching lines @@
     'unsigned long': PrimitiveIDLTypeInfo('unsigned long', dart_type='int',
         native_type='unsigned',
         webcore_getter_name='getUnsignedIntegralAttribute',
         webcore_setter_name='setUnsignedIntegralAttribute'),
     'long long': PrimitiveIDLTypeInfo('long long', dart_type='int'),
     'unsigned long long': PrimitiveIDLTypeInfo('unsigned long long', dart_type='int'),
     'float': PrimitiveIDLTypeInfo('float', dart_type='num', native_type='double'),
     'double': PrimitiveIDLTypeInfo('double', dart_type='num'),
 
     'any': PrimitiveIDLTypeInfo('any', dart_type='Object'),
-    'any[]': PrimitiveIDLTypeInfo('any[]', dart_type='List'),
     'Array': PrimitiveIDLTypeInfo('Array', dart_type='List'),
     'custom': PrimitiveIDLTypeInfo('custom', dart_type='Dynamic'),
     'Date': PrimitiveIDLTypeInfo('Date', dart_type='Date', native_type='double'),
     'DOMObject': PrimitiveIDLTypeInfo('DOMObject', dart_type='Object', native_type='ScriptValue'),
     'DOMString': PrimitiveIDLTypeInfo('DOMString', dart_type='String', native_type='String'),
     # TODO(vsm): This won't actually work until we convert the Map to
     # a native JS Map for JS DOM.
     'Dictionary': PrimitiveIDLTypeInfo('Dictionary', dart_type='Map'),
     # TODO(sra): Flags is really a dictionary: {create:bool, exclusive:bool}
     # http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
     'Flags': PrimitiveIDLTypeInfo('Flags', dart_type='Object'),
     'DOMTimeStamp': PrimitiveIDLTypeInfo('DOMTimeStamp', dart_type='int', native_type='unsigned long long'),
     'object': PrimitiveIDLTypeInfo('object', dart_type='Object', native_type='ScriptValue'),
     'PositionOptions': PrimitiveIDLTypeInfo('PositionOptions', dart_type='Object'),
     # TODO(sra): Come up with some meaningful name so that where this appears in
     # the documentation, the user is made aware that only a limited subset of
     # serializable types are actually permitted.
     'SerializedScriptValue': PrimitiveIDLTypeInfo('SerializedScriptValue', dart_type='Dynamic'),
     # TODO(sra): Flags is really a dictionary: {create:bool, exclusive:bool}
     # http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
     'WebKitFlags': PrimitiveIDLTypeInfo('WebKitFlags', dart_type='Object'),
 
     'sequence': PrimitiveIDLTypeInfo('sequence', dart_type='List'),
     'void': PrimitiveIDLTypeInfo('void', dart_type='void'),
 
     'CSSRule': IDLTypeInfo('CSSRule', conversion_includes=['CSSImportRule']),
     'DOMException': IDLTypeInfo('DOMException', native_type='DOMCoreException'),
+    'DOMString[]': IDLTypeInfo('DOMStringList', dart_type='List<String>', custom_to_native=True),

[podivilov, 2012/06/20 15:08:39]

Is there any difference between DOMString[] and DOMStringList? Shouldn't we
treat them differently in Dart?

[Anton Muhin, 2012/06/20 15:13:54]

For now I just followed v8 bindings which apparently treat them as same things.

On 2012/06/20 15:08:39, podivilov wrote:

[podivilov, 2012/06/20 15:54:46]

If they are the same things, we should just fix the IDLs upstream.
But I believe they are treated differently by CodeGeneratorV8.pm.

[sra1, 2012/06/20 16:33:26]

I think that they are not the same.
On Chrome the methods returning DOMStringList return an object x with the
x.constructor.name == 'DOMStringList'.
We need to know which are declared as returning or taking DOMStringList for the
JS bindings, since we will have to inject different tests and possibly a
different conversion there.

[Anton Muhin, 2012/06/20 18:45:47]

Sorry, I indeed missed that they create a fresh array when convert returned
result.  Fixed.

     'DOMStringList': IDLTypeInfo('DOMStringList', dart_type='List<String>', custom_to_native=True),
     'DOMStringMap': IDLTypeInfo('DOMStringMap', dart_type='Map<String, String>'),
     'DOMWindow': IDLTypeInfo('DOMWindow', custom_to_dart=True),
     'Element': IDLTypeInfo('Element', custom_to_dart=True),
     'EventListener': IDLTypeInfo('EventListener', custom_to_native=True),
     'EventTarget': IDLTypeInfo('EventTarget', custom_to_native=True),
     'HTMLElement': IDLTypeInfo('HTMLElement', custom_to_dart=True),
     'IDBAny': IDLTypeInfo('IDBAny', dart_type='Dynamic', custom_to_native=True),
     'IDBKey': IDLTypeInfo('IDBKey', dart_type='Dynamic', custom_to_native=True),
     'StyleSheet': IDLTypeInfo('StyleSheet', conversion_includes=['CSSStyleSheet']),
@@ skipping 18 matching lines @@
 _svg_supplemental_includes = [
     '"SVGAnimatedPropertyTearOff.h"',
     '"SVGAnimatedListPropertyTearOff.h"',
     '"SVGStaticListPropertyTearOff.h"',
     '"SVGAnimatedListPropertyTearOff.h"',
     '"SVGTransformListPropertyTearOff.h"',
     '"SVGPathSegListPropertyTearOff.h"',
 ]
 
 def GetIDLTypeInfo(idl_type_name):
+  type_info = _idl_type_registry.get(idl_type_name)
+  if type_info is not None:
+    return type_info
+
   match = re.match(r'sequence<(\w+)>$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
-  return _idl_type_registry.get(idl_type_name, IDLTypeInfo(idl_type_name))
+
+  match = re.match(r'(\w+)\[\]$', idl_type_name)
+  if match:
+    return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
+
+  return IDLTypeInfo(idl_type_name)