Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10584019: sync: Remove ClearUserData command. (Closed)

Created:
8 years, 6 months ago by tim (not reviewing)
Modified:
8 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

sync: Remove ClearUserData command. BUG=131336 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143088

Patch Set 1 #

Patch Set 2 : review 1 #

Patch Set 3 : fix test #

Patch Set 4 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -599 lines) Patch
M chrome/browser/sync/glue/sync_backend_host.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 6 chunks +0 lines, -47 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 6 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 4 chunks +0 lines, -50 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
M sync/engine/all_status.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D sync/engine/clear_data_command.h View 1 chunk +0 lines, -31 lines 0 comments Download
D sync/engine/clear_data_command.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D sync/engine/clear_data_command_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M sync/engine/sync_engine_event.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sync/engine/sync_scheduler.h View 3 chunks +0 lines, -8 lines 0 comments Download
M sync/engine/sync_scheduler.cc View 6 chunks +1 line, -19 lines 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M sync/engine/sync_scheduler_whitebox_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M sync/engine/syncer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/syncer.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M sync/internal_api/debug_info_event_listener.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/internal_api/debug_info_event_listener.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 2 chunks +0 lines, -8 lines 0 comments Download
M sync/internal_api/sync_manager.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M sync/internal_api/syncapi_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/protocol/get_updates_caller_info.proto View 1 1 chunk +4 lines, -1 line 0 comments Download
M sync/protocol/proto_enum_conversions.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sync/protocol/proto_enum_conversions_unittest.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M sync/protocol/sync.proto View 3 chunks +6 lines, -12 lines 0 comments Download
M sync/sync.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M sync/test/engine/mock_connection_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/test/engine/mock_connection_manager.cc View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tim (not reviewing)
Richard, please review! I left the GetUpdatesCallerInfo enum value... maybe we should comment it out?
8 years, 6 months ago (2012-06-19 19:10:00 UTC) #1
rlarocque
28 files changed, 9 insertions(+), 532 deletions(-) => LGTM! On 2012/06/19 19:10:00, timsteele wrote: > ...
8 years, 6 months ago (2012-06-19 19:21:29 UTC) #2
tim (not reviewing)
Removed GetUpdatesCallerInfo enum value.
8 years, 6 months ago (2012-06-19 20:27:43 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 21:45:18 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698