Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: samples/tests/dartc/test_config.dart

Issue 10584014: Change test scripts to use Path library in most places, instead of strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address my own comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/test_config.dart » ('j') | tools/test-runtime.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/tests/dartc/test_config.dart
diff --git a/samples/tests/dartc/test_config.dart b/samples/tests/dartc/test_config.dart
index 87cca356a78cea0ce4541ea14f560eceb5a6212b..e14420ddd141ad3ddbf0c41c369203a38e98a02f 100644
--- a/samples/tests/dartc/test_config.dart
+++ b/samples/tests/dartc/test_config.dart
@@ -4,6 +4,7 @@
#library("client_dartc_test_config");
+#import("dart:io");
#import("../../../tools/testing/dart/test_suite.dart");
class SamplesDartcTestSuite extends DartcCompilationTestSuite {
@@ -42,7 +43,8 @@ class SamplesDartcTestSuite extends DartcCompilationTestSuite {
// Using readOptionsFromFile here causes the file to be read twice,
// because readOptionsFromFile is called again in the superclass.
// Avoid this in new code.
- return readOptionsFromFile(filename)["containsLeadingHash"];
+ return readOptionsFromFile(new Path.fromNative(filename))
+ ["containsLeadingHash"];
}
bool listRecursively() => true;
« no previous file with comments | « no previous file | tests/co19/test_config.dart » ('j') | tools/test-runtime.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698