Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10584009: Refactor the collection of initializer list types (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed last round of comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/enqueue.dart ('k') | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 5635bd0b1c1fd024b53a4f3da6d0ca37161dc0fd..3a5f38cb722b1fc42f6e091eda72e75cf197fa6b 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -1730,9 +1730,9 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
buffer.add(name);
Type type = node.receiver.propagatedType.computeType(compiler);
if (type != null) {
- world.registerFieldSetter(node.element.name,
- type,
- node.value.isInteger());
+ world.registerFieldSetter(node.element.name, type);
+ backend.updateFieldIntegerSetters(node.element,
+ node.value.isInteger());
}
buffer.add(' = ');
use(node.value, JSPrecedence.ASSIGNMENT_PRECEDENCE);
@@ -1772,10 +1772,8 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
includeBackendMembers: true,
includeSuperMembers: true,
f: (ClassElement enclosingClass, Element member) {
- world.registerFieldInitializer(member.name,
- enclosingClass.computeType(compiler),
- node.inputs[i].isInteger());
-
+ backend.updateFieldInitializers(member,
+ node.inputs[i].propagatedType);
i++;
});
String jsClassReference = compiler.namer.isolateAccess(node.element);
« no previous file with comments | « lib/compiler/implementation/enqueue.dart ('k') | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698