Issue 10584005: Mouse events pass through Mac Fullscreen Exit Bubble for Mouse Lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10584005: Mouse events pass through Mac Fullscreen Exit Bubble for Mouse Lock. (Closed)

Created:
8 years, 6 months ago by scheib

Modified:
8 years, 6 months ago

Reviewers:
jeremya, Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mouse events pass through Mac Fullscreen Exit Bubble for Mouse Lock. BUG=132183 TEST=Manual test as described in bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143189

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/10584005/diff/1/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (right): http://codereview.chromium.org/10584005/diff/1/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm#newcode82 chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:82: bubbleType_ == FEB_TYPE_MOUSELOCK_EXIT_INSTRUCTION) These two types have no button ...

8 years, 6 months ago (2012-06-20 15:49:58 UTC) #3

scheib

8 years, 6 months ago (2012-06-20 16:41:00 UTC) #4

Thanks.

http://codereview.chromium.org/10584005/diff/1/chrome/browser/ui/cocoa/fullsc...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (right):

http://codereview.chromium.org/10584005/diff/1/chrome/browser/ui/cocoa/fullsc...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:82: bubbleType_ ==
FEB_TYPE_MOUSELOCK_EXIT_INSTRUCTION)
On 2012/06/20 15:49:58, Nico wrote:
> These two types have no button on the bubble, right? If so, lgtm

Correct, these are exit instructions only for mouse lock (so nothing is
clickable).

Expand Messages | Collapse Messages