Issue 10583010: Merge 120257 - Padding and borders can cause integer overflow in block layouts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10583010: Merge 120257 - Padding and borders can cause integer overflow in block layouts (Closed)

Created:
8 years, 6 months ago by Julien - ping for review

Modified:
8 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/

Visibility:
Public.

More Reviews

Description

Merge 120257 - Padding and borders can cause integer overflow in block layouts https://bugs.webkit.org/show_bug.cgi?id=88820 < rdar://problem/11328762> Reviewed by Tony Chang. Source/WebCore: Tests: fast/block/block-size-integer-overflow.html fast/flexbox/box-size-integer-overflow.html fast/table/table-size-integer-overflow.html * rendering/AutoTableLayout.cpp: Decreased max int. (WebCore::AutoTableLayout::computePreferredLogicalWidths): * rendering/FixedTableLayout.cpp: Use shared constant. (WebCore::FixedTableLayout::computePreferredLogicalWidths): * rendering/RenderBlock.cpp: Removed unused constant. * rendering/TableLayout.h: Add shared constant. (TableLayout): LayoutTests: * fast/block/block-size-integer-overflow-expected.txt: Added. * fast/block/block-size-integer-overflow.html: Added. * fast/flexbox/box-size-integer-overflow-expected.txt: Added. * fast/flexbox/box-size-integer-overflow.html: Added. * fast/table/table-size-integer-overflow-expected.txt: Added. * fast/table/table-size-integer-overflow.html: Added. TBR=tc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120656

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -7 lines)			Patch
A +	LayoutTests/fast/block/block-size-integer-overflow.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/block/block-size-integer-overflow-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/flexbox/box-size-integer-overflow.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/flexbox/box-size-integer-overflow-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/table/table-size-integer-overflow.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/table/table-size-integer-overflow-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/rendering/AutoTableLayout.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/WebCore/rendering/FixedTableLayout.cpp	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	Source/WebCore/rendering/RenderBlock.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/WebCore/rendering/TableLayout.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download