Issue 10582028: Re-factor TraySms to use ash::SmsObserver instead of NetoworkSmsHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10582028: Re-factor TraySms to use ash::SmsObserver instead of NetoworkSmsHandler. (Closed)

Created:
8 years, 6 months ago by stevenjb

Modified:
8 years, 6 months ago

Reviewers:
Dmitry Polukhin, oshima, sadrul

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-factor TraySms to use ash::SmsObserver instead of NetoworkSmsHandler. It turns out that the new SmsWatcher class does not work correctly if devices are added after it is initialized. This could be a problem with newly activated networks. For now, revert to using the existing, tested SmsObserver class in Chrome through the existing ash::SystemTrayDelegate. BUG=133569 TEST=See issue for testing details Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143291

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -136 lines)			Patch
A	ash/system/network/sms_observer.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	ash/system/network/tray_sms.h	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	ash/system/network/tray_sms.cc	View	11 chunks	+32 lines, -116 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/profile_startup.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/sms_observer.cc	View	2 chunks	+23 lines, -7 lines	0 comments	Download
M	chromeos/network/network_sms_handler.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

sadrul: Please look at the ash/ changes dpolukhin: Please take a look at the chrome/ ...

8 years, 6 months ago (2012-06-19 23:27:51 UTC) #1

stevenjb

oshima, can you take a quick look at the Chrome changes? I'd like to get ...

8 years, 6 months ago (2012-06-20 21:41:09 UTC) #2

*/chromeos/* LGTM

Expand Messages | Collapse Messages