Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: webkit/media/webmediaplayer_impl.cc

Issue 10582026: Add UMA reporting for GpuVideoDecoder::Initialize status. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/media.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/webmediaplayer_impl.cc
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index 588801c471b6b9aaee85eff263a6347216c3f71d..d6c69c77bc097cf2614f81057aed453e37fd4762 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -827,7 +827,7 @@ void WebMediaPlayerImpl::OnPipelineError(PipelineStatus error) {
DCHECK_EQ(main_loop_, MessageLoop::current());
switch (error) {
case media::PIPELINE_OK:
- LOG(DFATAL) << "PIPELINE_OK isn't an error!";
+ NOTREACHED() << "PIPELINE_OK isn't an error!";
break;
case media::PIPELINE_ERROR_NETWORK:
@@ -859,6 +859,10 @@ void WebMediaPlayerImpl::OnPipelineError(PipelineStatus error) {
// Webkit (see http://crbug.com/124486).
SetNetworkState(WebMediaPlayer::NetworkStateDecodeError);
break;
+
+ case media::PIPELINE_STATUS_MAX:
+ NOTREACHED() << "PIPELINE_STATUS_MAX isn't a real error!";
+ break;
}
// Repaint to trigger UI update.
« no previous file with comments | « media/media.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698