compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java - Issue 10582013: Issue 1655. Check initializer values of const constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

Issue 10582013: Issue 1655. Check initializer values of const constructors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java ('K') | « compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

index 3f82debc0ed8c7a8e535a3daaef16d1e389e4577..96c866341384794ec3c66b64a682cc99935860ad 100644

--- a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java

@@ -181,6 +181,14 @@ public class CompileTimeConstantResolver {

resolveConstantExpression(node.getValue());

return null;

}

+ @Override

+ public Element visitInitializer(DartInitializer node) {

+ if (node.getInitializerName() != null) {

+ resolveConstantExpression(node.getValue());

+ }

+ return super.visitInitializer(node);

+ }

@Override

public Element visitMethodDefinition(DartMethodDefinition node) {